Skip to content

Helmfile updates (0.16.0 -> 0.19.0, use wrapProgram)#42099

Merged
xeji merged 2 commits intoNixOS:masterfrom
kliu128:helmfile-updates
Jun 18, 2018
Merged

Helmfile updates (0.16.0 -> 0.19.0, use wrapProgram)#42099
xeji merged 2 commits intoNixOS:masterfrom
kliu128:helmfile-updates

Conversation

@kliu128
Copy link

@kliu128 kliu128 commented Jun 16, 2018

Motivation for this change

https://github.com/roboll/helmfile/releases/tag/v0.19.0 and helmfile only worked if Kubernetes Helm was explicitly installed alongside.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Kevin Liu added 2 commits June 16, 2018 08:40
Helmfile makes direct calls to `helm` as an implicit dependency. Now helmfile
can work without Helm also being explicitly installed.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 16, 2018
@xeji
Copy link
Contributor

xeji commented Jun 18, 2018

@GrahamcOfBorg build helmfile

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: helmfile

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: helmfile

Partial log (click to expand)

strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g009hlai1jqp7q75n65ak4r2l821dp3z-helmfile-0.19.0-bin/bin
patching script interpreter paths in /nix/store/g009hlai1jqp7q75n65ak4r2l821dp3z-helmfile-0.19.0-bin
checking for references to /build in /nix/store/g009hlai1jqp7q75n65ak4r2l821dp3z-helmfile-0.19.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/8r9qhiszjfrzpfs7387rjjri0cs39msw-helmfile-0.19.0
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8r9qhiszjfrzpfs7387rjjri0cs39msw-helmfile-0.19.0
/nix/store/8r9qhiszjfrzpfs7387rjjri0cs39msw-helmfile-0.19.0/share/go/src/github.com/roboll/helmfile/test/integration/run.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/8r9qhiszjfrzpfs7387rjjri0cs39msw-helmfile-0.19.0...
/nix/store/g009hlai1jqp7q75n65ak4r2l821dp3z-helmfile-0.19.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: helmfile

Partial log (click to expand)

/private/tmp/nix-build-helmfile-0.19.0.drv-0/go /private/tmp/nix-build-helmfile-0.19.0.drv-0
/private/tmp/nix-build-helmfile-0.19.0.drv-0
post-installation fixup
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/g7sbgz5z25ylr06km4b6l5bvpg954v1q-helmfile-0.19.0-bin/bin
patching script interpreter paths in /nix/store/g7sbgz5z25ylr06km4b6l5bvpg954v1q-helmfile-0.19.0-bin
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/6qvxwz7ka8k52cd7wribxmhh91ajl8q1-helmfile-0.19.0
/nix/store/6qvxwz7ka8k52cd7wribxmhh91ajl8q1-helmfile-0.19.0/share/go/src/github.com/roboll/helmfile/test/integration/run.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/bash"
/nix/store/g7sbgz5z25ylr06km4b6l5bvpg954v1q-helmfile-0.19.0-bin

@xeji xeji merged commit a28e7f2 into NixOS:master Jun 18, 2018
@kliu128 kliu128 deleted the helmfile-updates branch June 18, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants