Skip to content

Comments

webcord-vencord: bump electron to electron_36#420519

Merged
TomaSajt merged 1 commit intoNixOS:masterfrom
NotAShelf:webcord-bump
Jun 30, 2025
Merged

webcord-vencord: bump electron to electron_36#420519
TomaSajt merged 1 commit intoNixOS:masterfrom
NotAShelf:webcord-bump

Conversation

@NotAShelf
Copy link
Member

Bumps webcord-vencord's Electron version to 36, from 34, in light of the recent
EOL for Electron 34. Upstream does have a history of not playing nicely with
recent Electron versions, but as per my testing. the window itself opens
perfectly fine. I unfortunately cannot test further functionality as Discord is
banned in my country, and I cannot get past the initial loading screen.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See
    Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using
    nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all
    changes have to be committed, also see
    nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in
    ./result/bin/)
  • Nixpkgs 25.11 Release Notes
    (or backporting
    24.11
    and
    25.05
    Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or
      breaking
  • NixOS 25.11 Release Notes
    (or backporting
    24.11
    and
    25.05
    NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is
      significant
    • (Module addition) Added a release notes entry if adding a new NixOS
      module
  • Fits
    CONTRIBUTING.md,
    pkgs/README.md,
    maintainers/README.md
    and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 27, 2025
@TomaSajt
Copy link
Contributor

Did some minimal testing, seems to run fine.
Hopefully everything still works.
Will merge now.

@TomaSajt TomaSajt changed the title webcord: bump electron to electron_36 webcord-vencord: bump electron to electron_36 Jun 30, 2025
@TomaSajt TomaSajt merged commit 8e0ecc5 into NixOS:master Jun 30, 2025
18 of 19 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 30, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants