webcord-vencord: bump electron to electron_36#420519
Merged
TomaSajt merged 1 commit intoNixOS:masterfrom Jun 30, 2025
Merged
Conversation
22 tasks
Contributor
|
Did some minimal testing, seems to run fine. |
electron_36electron_36
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps webcord-vencord's Electron version to 36, from 34, in light of the recent
EOL for Electron 34. Upstream does have a history of not playing nicely with
recent Electron versions, but as per my testing. the window itself opens
perfectly fine. I unfortunately cannot test further functionality as Discord is
banned in my country, and I cannot get past the initial loading screen.
Things done
nix.conf? (SeeNix manual)
sandbox = relaxedsandbox = true(look inside
nixos/tests)
package tests
lib/tests or
pkgs/test
linked
to the relevant packages
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: allchanges have to be committed, also see
nixpkgs-review usage
./result/bin/)(or backporting
24.11
and
25.05
Nixpkgs Release notes)
breaking
(or backporting
24.11
and
25.05
NixOS Release notes)
significant
module
CONTRIBUTING.md,
pkgs/README.md,
maintainers/README.md
and other contributing documentation in corresponding paths.
Add a 👍 reaction to pull requests you find important.