Skip to content

wavpack: fix build#420493

Merged
wegank merged 2 commits intoNixOS:stagingfrom
alyssais:wavpack-gettext-0.25
Jun 29, 2025
Merged

wavpack: fix build#420493
wegank merged 2 commits intoNixOS:stagingfrom
alyssais:wavpack-gettext-0.25

Conversation

@alyssais
Copy link
Member

Patch has been submitted upstream but we'll need to fix this in some way for the next cycle regardless.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais requested review from wegank and yorickvP June 27, 2025 10:37
@alyssais alyssais mentioned this pull request Jun 27, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 27, 2025
@nix-owners nix-owners bot requested a review from codyopel June 27, 2025 10:44
alyssais added 2 commits June 27, 2025 12:52
Now that autoreconf runs autopoint, this is done for us automatically.
@alyssais alyssais force-pushed the wavpack-gettext-0.25 branch from 16d20d8 to a23150d Compare June 27, 2025 10:52
@wegank wegank merged commit 2cb6019 into NixOS:staging Jun 29, 2025
26 of 27 checks passed
@alyssais alyssais deleted the wavpack-gettext-0.25 branch July 7, 2025 10:21
@galenhuntington galenhuntington mentioned this pull request Jul 15, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants