nushellPlugins.desktop_notifications: init at 0.106.1#419914
Conversation
41d6efd to
c7a1c17
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5611 |
c7a1c17 to
70f326e
Compare
70f326e to
8597dc5
Compare
|
|
@NixOS/nixpkgs-vet I think https://github.com/NixOS/nixpkgs/actions/runs/16022597093/job/45202899627?pr=419914 failed for a reason not related to this pr. |
|
Correct, this is easily fixed by re-running the job (which I just triggered). We're aware of that failure mode already (#413239), but haven't been able to fix it, yet. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5728 |
There was a problem hiding this comment.
this uses an underscore and the PR title uses a dash and the filename uses a dash. which is right?
There was a problem hiding this comment.
Changed PR title. @dtomvan do you know if nu plugins follow a convention for package and file name? Do you want me to use - or _ for both?
There was a problem hiding this comment.
Nothing specific to nushell plugins AFAICT.
Relevant (general) package naming conventions snippets:
New attribute names should be the same as the value in pname.
Hyphenated names should not be converted to snake case or camel case. This was done historically, but is not necessary any more. The Nix language allows dashes in identifiers since 2012.
It should be identical to the upstream package name.
Given that the upstream name is nu_plugin_desktop_notifications I think the attrname nushellPlugins.desktop_notifications makes most sense, as pname also already reflects the upstream name with underscores too.
The file name should then probably also use underscores.
|
New release at 0.106.1 but otherwise LGTM |
8597dc5 to
78ced76
Compare
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2527 |
https://github.com/FMotalleb/nu_plugin_desktop_notifications
closes #374678
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.