Skip to content

nushellPlugins.desktop_notifications: init at 0.106.1#419914

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
timon-schelling:init-nushellPlugins-desktop-notifications
Aug 25, 2025
Merged

nushellPlugins.desktop_notifications: init at 0.106.1#419914
philiptaron merged 1 commit intoNixOS:masterfrom
timon-schelling:init-nushellPlugins-desktop-notifications

Conversation

@timon-schelling
Copy link
Member

https://github.com/FMotalleb/nu_plugin_desktop_notifications

closes #374678

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 25, 2025
@timon-schelling timon-schelling force-pushed the init-nushellPlugins-desktop-notifications branch 2 times, most recently from 41d6efd to c7a1c17 Compare June 26, 2025 12:22
@timon-schelling timon-schelling changed the title nushellPlugins.desktop-notifications: init at 1.2.12 nushellPlugins.desktop-notifications: init at 0.105.1 Jun 26, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jun 26, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5611

@timon-schelling timon-schelling force-pushed the init-nushellPlugins-desktop-notifications branch from c7a1c17 to 70f326e Compare June 27, 2025 22:51
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 30, 2025
@timon-schelling timon-schelling marked this pull request as draft July 2, 2025 10:21
@timon-schelling timon-schelling force-pushed the init-nushellPlugins-desktop-notifications branch from 70f326e to 8597dc5 Compare July 2, 2025 10:24
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 2, 2025
@timon-schelling timon-schelling marked this pull request as ready for review July 2, 2025 10:25
@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jul 2, 2025
@timon-schelling
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 419914

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/16022615146


x86_64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop_notifications

aarch64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop_notifications

@timon-schelling
Copy link
Member Author

@NixOS/nixpkgs-vet

I think https://github.com/NixOS/nixpkgs/actions/runs/16022597093/job/45202899627?pr=419914 failed for a reason not related to this pr.

@wolfgangwalther
Copy link
Contributor

Correct, this is easily fixed by re-running the job (which I just triggered). We're aware of that failure mode already (#413239), but haven't been able to fix it, yet.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5728

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 2, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this uses an underscore and the PR title uses a dash and the filename uses a dash. which is right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed PR title. @dtomvan do you know if nu plugins follow a convention for package and file name? Do you want me to use - or _ for both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing specific to nushell plugins AFAICT.

Relevant (general) package naming conventions snippets:

New attribute names should be the same as the value in pname.

Hyphenated names should not be converted to snake case or camel case. This was done historically, but is not necessary any more. The Nix language allows dashes in identifiers since 2012.

It should be identical to the upstream package name.

Given that the upstream name is nu_plugin_desktop_notifications I think the attrname nushellPlugins.desktop_notifications makes most sense, as pname also already reflects the upstream name with underscores too.

The file name should then probably also use underscores.

@timon-schelling timon-schelling changed the title nushellPlugins.desktop-notifications: init at 0.105.1 nushellPlugins.desktop_notifications: init at 0.105.1 Aug 2, 2025
@philiptaron
Copy link
Contributor

New release at 0.106.1 but otherwise LGTM

@timon-schelling timon-schelling marked this pull request as draft August 2, 2025 23:39
@timon-schelling timon-schelling force-pushed the init-nushellPlugins-desktop-notifications branch from 8597dc5 to 78ced76 Compare August 2, 2025 23:54
@timon-schelling timon-schelling changed the title nushellPlugins.desktop_notifications: init at 0.105.1 nushellPlugins.desktop_notifications: init at 0.106.1 Aug 2, 2025
@timon-schelling timon-schelling marked this pull request as ready for review August 2, 2025 23:55
@timon-schelling
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 419914

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/16698986600


x86_64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop_notifications

aarch64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop_notifications

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2527

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 25, 2025
@philiptaron philiptaron merged commit d2a68bf into NixOS:master Aug 25, 2025
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: nushellPlugins.desktop-notifications

7 participants