Skip to content

Comments

rstudio: bump electron version#419913

Merged
TomaSajt merged 1 commit intoNixOS:masterfrom
TomaSajt:rstudio
Jun 29, 2025
Merged

rstudio: bump electron version#419913
TomaSajt merged 1 commit intoNixOS:masterfrom
TomaSajt:rstudio

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jun 25, 2025

Tracking issue: #419903

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 25, 2025
@nix-owners nix-owners bot requested a review from ciil June 25, 2025 15:13
@TomaSajt TomaSajt marked this pull request as draft June 25, 2025 15:39
@TomaSajt TomaSajt marked this pull request as ready for review June 25, 2025 15:47
@b-rodrigues
Copy link
Contributor

b-rodrigues commented Jun 29, 2025

on macOS, there seems to be something wrong with texlive

/nix/store/hiqmcggcgrz8mrbhpla7ik1bjvmm9yxp-texlive-bin-big-2025/lib/libtexluajit.2.dylib -compatibility_version 4 -current_version 4.81742 -Wl,-single_module
ld: malformed 64-bit a.b.c.d.e version number: 4.81742
clang: �[0;1;31merror: �[0m�[1mlinker command failed with exit code 1 (use -v to see invocation)�[0m
make[5]: *** [Makefile:1075: libtexluajit.la] Error 1
make[5] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs/luajit »
make[4]: *** [Makefile:1312: all-recursive] Error 1
make[4] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs/luajit »
make[3]: *** [Makefile:859: all] Error 2
make[3] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs/luajit »
make[2]: *** [Makefile:913: recurse] Error 1
make[2] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs »
make[1]: *** [Makefile:484: all-recursive] Error 1
make[1] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs »
make: *** [Makefile:580: all-recursive] Error 1

@b-rodrigues
Copy link
Contributor

b-rodrigues commented Jun 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419913
Commit: a2a5367191218126e63cbda85bbb203d192155af


x86_64-linux

✅ 4 packages built:
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper

@b-rodrigues
Copy link
Contributor

on macOS, there seems to be something wrong with texlive

/nix/store/hiqmcggcgrz8mrbhpla7ik1bjvmm9yxp-texlive-bin-big-2025/lib/libtexluajit.2.dylib -compatibility_version 4 -current_version 4.81742 -Wl,-single_module
ld: malformed 64-bit a.b.c.d.e version number: 4.81742
clang: �[0;1;31merror: �[0m�[1mlinker command failed with exit code 1 (use -v to see invocation)�[0m
make[5]: *** [Makefile:1075: libtexluajit.la] Error 1
make[5] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs/luajit »
make[4]: *** [Makefile:1312: all-recursive] Error 1
make[4] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs/luajit »
make[3]: *** [Makefile:859: all] Error 2
make[3] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs/luajit »
make[2]: *** [Makefile:913: recurse] Error 1
make[2] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs »
make[1]: *** [Makefile:484: all-recursive] Error 1
make[1] : on quitte le répertoire « /private/tmp/nix-build-texlive-bin-big-2025.drv-0/texlive-20250308-source/WorkDir/libs »
make: *** [Makefile:580: all-recursive] Error 1

but that seems to be the case on master as well currently

@b-rodrigues b-rodrigues mentioned this pull request Jun 29, 2025
3 tasks
Copy link
Contributor

@Kupac Kupac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great and functional. Both the desktop and server versions on x86-64-linuix. The visual mode keeps working.
image

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 29, 2025
@TomaSajt TomaSajt merged commit b54a112 into NixOS:master Jun 29, 2025
26 of 28 checks passed
@TomaSajt
Copy link
Contributor Author

Opened a combined backport PR: #421106

I don't think there were any changes to the package that would break anyone's workflow so I think this should be fine to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants