Skip to content

redisTestHook: fix failure when run directory already exists#419823

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
niklaskorz:fix-redistesthook
Jun 25, 2025
Merged

redisTestHook: fix failure when run directory already exists#419823
mweinelt merged 1 commit intoNixOS:stagingfrom
niklaskorz:fix-redistesthook

Conversation

@niklaskorz
Copy link
Member

The redisTestHook currently assumes that $NIX_BUILD_TOP/run does not exist already when it's run, thus causing a failure if another hook created this directory before it (e.g., postgresqlTestHook).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 25, 2025
@niklaskorz niklaskorz changed the base branch from master to staging June 25, 2025 09:23
@nixpkgs-ci nixpkgs-ci bot closed this Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Jun 25, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2025
@niklaskorz
Copy link
Member Author

-p was originally used for the mkdir but (accidentally?) removed in #408185 (cc @mweinelt)

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 25, 2025
@mweinelt mweinelt merged commit 643a515 into NixOS:staging Jun 25, 2025
34 of 40 checks passed
@mweinelt
Copy link
Member

mweinelt commented Jun 25, 2025

In 52ccfdf to be precise. And yes, accidentally.

@niklaskorz niklaskorz deleted the fix-redistesthook branch November 10, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants