Skip to content

deno: 2.3.6 -> 2.3.7#419511

Merged
pbsds merged 2 commits intoNixOS:masterfrom
ofalvai:push-rxqtxmpmknzu
Jun 25, 2025
Merged

deno: 2.3.6 -> 2.3.7#419511
pbsds merged 2 commits intoNixOS:masterfrom
ofalvai:push-rxqtxmpmknzu

Conversation

@ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Jun 24, 2025

Besides the version bump, I fixed the update script. Since #384838, we are fetching git submodules, so the updater script should fetch them too in order to produce the right hash.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 24, 2025
@nix-owners nix-owners bot requested a review from 06kellyjac June 24, 2025 10:30
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 24, 2025
@06kellyjac
Copy link
Member

06kellyjac commented Jun 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419511


x86_64-linux

❌ 3 packages failed to build:
  • rstudio-server
  • rstudioServerWrapper
  • windmill
✅ 20 packages built:
  • deno
  • era
  • gleam
  • quarto
  • quartoMinimal
  • rstudio
  • rstudioWrapper
  • silverbullet
  • vimPlugins.ddc-filter-matcher_head
  • vimPlugins.ddc-filter-sorter_rank
  • vimPlugins.ddc-fuzzy
  • vimPlugins.ddc-source-around
  • vimPlugins.ddc-source-file
  • vimPlugins.ddc-source-lsp
  • vimPlugins.ddc-ui-native
  • vimPlugins.ddc-ui-pum
  • vimPlugins.ddc-vim
  • vimPlugins.denops-vim
  • vimPlugins.peek-nvim
  • vimPlugins.vim-pluto

Rstuido has a gcc build error

c/Warning-Options.html#index-Wno-null-dereference-Wnull-dereference8;;]
       > include/boost/multi_index/detail/seq_index_node.hpp:61:23: warning: potential null pointer dereference [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-null-dereference-Wnull-dereference8;;]
       > In file included from include/boost/regex/v5/regex.hpp:67,
       >                  from include/boost/regex.hpp:34,
       >                  from /build/source/src/cpp/core/include/core/HtmlUtils.hpp:21,
       >                  from /build/source/src/cpp/session/include/session/SessionModuleContext.hpp:31:
       > In member function 'bool boost::regex_token_iterator_implementation<BidirectionalIterator, charT, traits>::next() [with BidirectionalIterator = __gnu_cxx::__normal_iterator<const char*, std::__cxx11::basic_string<char> >; charT = char; traits = boost::regex_traits<char>]',
       >     inlined from 'boost::regex_token_iterator<BidirectionalIterator, charT, traits>& boost::regex_token_iterator<BidirectionalIterator, charT, traits>::operator++() [with BidirectionalIterator = __gnu_cxx::__normal_iterator<const char*, std::__cxx11::basic_string<char> >; charT = char; traits = boost::regex_traits<char>]' at include/boost/regex/v5/regex_token_iterator.hpp:185:26,
       >     inlined from 'rstudio::core::Version::Version(std::string)' at /build/source/src/cpp/core/include/core/Version.hpp:49:30:
       > include/boost/regex/v5/regex_token_iterator.hpp:92:10: warning: potential null pointer dereference [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-null-dereference-Wnull-dereference8;;]
       > make[1]: *** [CMakeFiles/Makefile2:1461: src/cpp/session/CMakeFiles/rsession.dir/all] Error 2
       > make: *** [Makefile:156: all] Error 2

windmill is failing with a panic when compiling

I'd guess these are existing failures but I've not checked

@pbsbot
Copy link

pbsbot commented Jun 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419511
Commit: 366b94f6121a64c2b5da2bf7c77c06c6a69974ac


x86_64-linux

✅ 11 packages built:
  • deno
  • era
  • gleam
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet
  • windmill

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 25, 2025
@pbsbot
Copy link

pbsbot commented Jun 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419511 --eval local
Commit: 366b94f6121a64c2b5da2bf7c77c06c6a69974ac


x86_64-linux

✅ 23 packages built:
  • deno
  • era
  • gleam
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet
  • vimPlugins.ddc-filter-matcher_head
  • vimPlugins.ddc-filter-sorter_rank
  • vimPlugins.ddc-fuzzy
  • vimPlugins.ddc-source-around
  • vimPlugins.ddc-source-file
  • vimPlugins.ddc-source-lsp
  • vimPlugins.ddc-ui-native
  • vimPlugins.ddc-ui-pum
  • vimPlugins.ddc-vim
  • vimPlugins.denops-vim
  • vimPlugins.peek-nvim
  • vimPlugins.vim-pluto
  • windmill

@pbsds
Copy link
Member

pbsds commented Jun 25, 2025

Not sure why there is such a big difference between the gha eval and local eval.

cc @wolfgangwalther @infinisil in case this is not on your radar at all. Skimming a bit it seems the main difference between nixpkgs-review and GHA eval is invoking nix-env with chunking? ref fbbe972898fc2

@pbsds pbsds merged commit 06db462 into NixOS:master Jun 25, 2025
32 of 34 checks passed
@wolfgangwalther
Copy link
Contributor

vimPlugins have meta.hydraPlatforms = [ ]. This means they are technically no "rebuilds" and thus are not eval'ed in CI.

@pbsds
Copy link
Member

pbsds commented Jun 25, 2025

Thanks, TIL 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants