html2text, wavpack, pinentry_mac, dosfstools: fix build with gettext 0.24.1+

[wegank]

#405793 (comment)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
• NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

---

Add a 👍 reaction to pull requests you find important.

[wegank]

@trofi, may I have your opinion on the hook added in this PR?

[eikek]

Thank you

[alyssais]

Would it not be better to fix the configure.ac files for these packages? There aren't many of them.

[wegank]

I'd very much like to (and that's why I skipped libmtp and xdg-user-dirs which have upstream(ing) fixes, see #405793 (comment)).

But I still feel that such a hammer is necessary for now, as I'm not at all sure how many packages could be broken by the gettext bump (given that we've already identified six, and the staging-next iteration hasn't even begun)...

[alyssais]

But I still feel that such a hammer is necessary for now, as I'm not at all sure how many packages could be broken by the gettext bump (given that we've already identified six, and the staging-next iteration hasn't even begun)...

I really think we'll spend more time with this approach overall, once we take into account that we're going to be cleaning these up forever because it won't be obvious when they're no longer necessary, whereas with patches it's much more likely that things will get cleaned up as they become obsolete because the patch will no longer apply.

[alyssais]

Only one left here that hasn't been fixed properly is now pinentry_mac. Maybe somebody who uses macOS could have a look at that?