haskellPackages.tree-diff: disable flaky test / failing on edge case#419207
Merged
vcunat merged 1 commit intoNixOS:stagingfrom Jun 29, 2025
Merged
haskellPackages.tree-diff: disable flaky test / failing on edge case#419207vcunat merged 1 commit intoNixOS:stagingfrom
vcunat merged 1 commit intoNixOS:stagingfrom
Conversation
Member
Author
|
@vcunat Does backporting to 24.11 make sense at this point? |
github-actions
bot
added
10.rebuild-linux: 501+
There hasn't been movement on this in many years since the package seems to be in maintenance mode only, but it is a prominently used dependency, so we'll have to ignore this, pretty much. Reference haskellari/tree-diff#79. Reference NixOS#384127 (comment).
sternenseemann
force-pushed
the
tree-diff-disable-tests
branch
from
d15286c to
50b7532
Compare
Member
|
It is possible that |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-24.11
git worktree add -d .worktree/backport-419207-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-419207-to-staging-24.11
git switch --create backport-419207-to-staging-24.11
git cherry-pick -x 50b75325305279d26777f6c7790cf9b64c2993d9 |
1 task
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There hasn't been movement on this in many years since the package seems to be in maintenance mode only, but it is a prominently used dependency, so we'll have to ignore this, pretty much.
Reference haskellari/tree-diff#79. Reference #384127 (comment).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.