Skip to content

[Backport release-25.05] nixos-rebuild-ng: validate NixOS config path in target host#419065

Merged
thiagokokada merged 1 commit intorelease-25.05from
backport-419006-to-release-25.05
Jun 22, 2025
Merged

[Backport release-25.05] nixos-rebuild-ng: validate NixOS config path in target host#419065
thiagokokada merged 1 commit intorelease-25.05from
backport-419006-to-release-25.05

Conversation

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Jun 22, 2025

Bot-based backport to release-25.05, triggered by a label in #419006.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

In #418243 we started to validate NixOS config path to avoid a nasty bug
in Nix, but this doesn't work in the `--build-host` and `--target-host`
case because the configuration will not be available in the local host
to check if it contains a `nixos-version`. This moves the check to
`--target-host` instead, that is probably the correct choice anyway.

Fix #418868.

(cherry picked from commit 0f6624e)
@nix-owners nix-owners bot requested a review from thiagokokada June 22, 2025 18:54
@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 4.workflow: backport This targets a stable branch labels Jun 22, 2025
@thiagokokada thiagokokada merged commit a8242ea into release-25.05 Jun 22, 2025
23 of 27 checks passed
@thiagokokada thiagokokada deleted the backport-419006-to-release-25.05 branch June 22, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant