Conversation
57523cb to
d354cb2
Compare
2419510 to
b25a1f1
Compare
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
|
|
||
| version = "4.4.3"; | ||
| version = "5.4.0"; | ||
| # ftfy v5 only supports python3. Since at the moment the only |
|
|
||
| disabled = isPyPy; | ||
|
|
||
| src = fetchurl { |
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
timokau
left a comment
There was a problem hiding this comment.
Apparently rpy2 2.9.x doesn't support python2 anymore:
rpy2 is no longer supporting Python < 3. Consider using an older rpy2 release when using an older Python release.
So we should probably keep a 2.8.x version around. And mark 2.9.x as python3 only.
| buildPythonPackage rec { | ||
| pname = "notebook"; | ||
| version = "5.4.1"; | ||
| version = "5.5.0"; |
There was a problem hiding this comment.
This breaks the build:
ERROR: Failure: ImportError (No module named selenium.webdriver.common.by)
There was a problem hiding this comment.
Adding selenium to checkInputs fixes it (selenium changelog: https://github.com/jupyter/notebook/blob/master/docs/source/changelog.rst).
Edit: I accidentally tested the downgraded package. It does fix the selenium import error, but it still doesn't build:
ERROR: notebook.tests.selenium.test_dashboard_nav.test_items
----------------------------------------------------------------------
Traceback (most recent call last):
File "/nix/store/n6m5xs9riz93p8np0ab131hjdmgpi028-python3.6-nose-1.3.7/lib/python3.6/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
TypeError: test_items() missing 1 required positional argument: 'authenticated_browser'
-------------------- >> begin captured logging << --------------------
NotebookApp: INFO: Shutting down 0 kernels
--------------------- >> end captured logging << ---------------------
and various other errors complaining about that same positional argument.
There was a problem hiding this comment.
I don't think we should test selenium at all - those tests are too brittle in my experience, the whole test suite could be deleted before building: https://github.com/jupyter/notebook/tree/ebe01762eb3e93b2c3f525eceb27ca6dd9611000/notebook/tests/selenium
|
Success on x86_64-darwin (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: aws-sam-cli, jrnl, pirate-get, python The following builds were skipped because they don't evaluate on x86_64-darwin: conan Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: aws-sam-cli, jrnl, pirate-get, python Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
|
The "python-dateutil: 1.5 -> 2.7.3" commit 07679a9 broke |
|
|
|
@FRidh You probably did not mean to bump the version in pkgs/development/python-modules/dateutil/1_5.nix either, right? |
|
@mbode Is this file used anywhere? |
|
@dotlambda I don't know, just randomly stumbled over it. I guess if it isn't, it should be deleted. |
Done in d7cce08. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)