Skip to content

victorialogs: init at 1.24.0#418806

Merged
yorickvP merged 5 commits intoNixOS:masterfrom
NyCodeGHG:victorialogs
Jun 23, 2025
Merged

victorialogs: init at 1.24.0#418806
yorickvP merged 5 commits intoNixOS:masterfrom
NyCodeGHG:victorialogs

Conversation

@NyCodeGHG
Copy link
Member

@NyCodeGHG NyCodeGHG commented Jun 21, 2025

Closes #418673

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@NyCodeGHG NyCodeGHG marked this pull request as ready for review June 21, 2025 17:52
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Jun 21, 2025
@github-actions github-actions bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 21, 2025
ryan4yin
ryan4yin approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@ryan4yin ryan4yin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 22, 2025
@FKouhai
Copy link
Member

FKouhai commented Jun 22, 2025

nixpkgs-review result for #418806

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 418806

Logs: https://github.com/FKouhai/nixpkgs-review-gha/actions/runs/15810235185

x86_64-linux (sandbox = true)

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 3 packages built:
  • nixpkgs-manual
  • victorialogs
  • victoriametrics

aarch64-linux (sandbox = true)

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 3 packages built:
  • nixpkgs-manual
  • victorialogs
  • victoriametrics

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • nixpkgs-manual
  • victorialogs
  • victoriametrics

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • nixpkgs-manual
  • victorialogs
  • victoriametrics

FKouhai
FKouhai approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@FKouhai FKouhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm

@FKouhai FKouhai added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jun 22, 2025
@yorickvP yorickvP merged commit cb6adfe into NixOS:master Jun 23, 2025
27 of 28 checks passed
@NyCodeGHG NyCodeGHG deleted the victorialogs branch June 23, 2025 15:06
@ryan4yin ryan4yin mentioned this pull request Jun 25, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivan ivan Awaiting requested review from ivan

@leona-ya leona-ya Awaiting requested review from leona-ya

@yorickvP yorickvP Awaiting requested review from yorickvP

3 more reviewers

@Shawn8901 Shawn8901 Shawn8901 approved these changes

@ryan4yin ryan4yin ryan4yin approved these changes

@FKouhai FKouhai FKouhai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

victorametrics: split victorialogs from metrics

5 participants

@NyCodeGHG @FKouhai @Shawn8901 @ryan4yin @yorickvP