Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
This comment was marked as outdated.
This comment was marked as outdated.
0xda157
reviewed
Jun 22, 2025
* Switched `rev` to `tag`. * Added `passthru.updateScript` * Removed `with lib;` from `meta` * Updated `meta.description` and `meta.longDescription` to reflect that there is a CLI tool too. * Adopted.
0xda157
approved these changes
Jun 23, 2025
Contributor
0xda157
left a comment
0xda157
left a comment
There was a problem hiding this comment.
LGTM. Could be split up into a few commits, I don't have strong feelings about it.
github-actions
bot
added
the
12.approvals: 1
Member
Author
|
Member
|
|
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-418487-to-release-24.11 origin/release-24.11
cd .worktree/backport-418487-to-release-24.11
git switch --create backport-418487-to-release-24.11
git cherry-pick -x 9d644e7eedb4abfb24b34185f9c27bfd1a99fb6f |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-418487-to-release-25.05 origin/release-25.05
cd .worktree/backport-418487-to-release-25.05
git switch --create backport-418487-to-release-25.05
git cherry-pick -x 9d644e7eedb4abfb24b34185f9c27bfd1a99fb6f |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revtotag.passthru.updateScriptwith lib;frommetameta.descriptionandmeta.longDescriptionto reflect that there is a CLI tool too.Closes: #258981
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.