[Backport release-25.05] workflows/pr: preparation for required status checks#418400
Merged
wolfgangwalther merged 5 commits intorelease-25.05from Jun 20, 2025
Merged
Conversation
Some naming improvements after we introduced the PR / Push workflows and small refactors. (cherry picked from commit 69ab2f4)
This is only a refactor at this stage, but split into a separate commit for better review. It's the base for the next two commits. (cherry picked from commit 9422f30)
This fixes a problem where each workflow would get their own merge commit. This happens frequently when the target branch is merged into a the same time, different workflows in the same run will run get-merge-commit at different times and thus have different merge commits. Since the jobs don't really depend on each other, this doesn't cause practical problems, yet. But it has already led to strange CI failures in a still unmerged PR, which can be prevented from happening with this clean approach. And yes, this saves a few API calls on every run. (cherry picked from commit 09ddb1a)
This allows *not* depending on those two jobs with the required status checks in the next commit, which wouldn't really make sense. If labeling or pinging maintainers fails for obscure reasons or because the GitHub API is down, a PR might still pass all other tests and be merge-eligible. (cherry picked from commit 9927d75)
This job serves as a target for the "Required Status Checks" branch protection rule. (cherry picked from commit caf4ced)
5 tasks
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
philiptaron,
risicle,
wolfgangwalther and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.05, triggered by a label in #417957.