python3Packages.plotly: 6.1.0 -> 6.1.2, unbreak on darwin#418321
Merged
GaetanLepage merged 2 commits intoNixOS:masterfrom Jun 23, 2025
Merged
python3Packages.plotly: 6.1.0 -> 6.1.2, unbreak on darwin#418321GaetanLepage merged 2 commits intoNixOS:masterfrom
GaetanLepage merged 2 commits intoNixOS:masterfrom
Conversation
Contributor
Author
|
Many unit tests were failing during NumPy import with the following error: RecursionError: maximum recursion depth exceeded. We had previously removed some tests for the same reason, but that patch was dropped in the recent update (#408185). However, the newly added tests are now causing failures on Darwin. Let’s disable them for now. detailsERROR tests/test_plotly_utils/validators/test_pandas_series_input.py::test_color_validator_categorical[Index] - RecursionError: maximum recursion depth exceeded
= 175 failed, 2855 passed, 21 skipped, 192 deselected, 4 xfailed, 686 warnings, 2 errors in 74.32s (0:01:14) =error: tests/test_plotly_utils/validators/test_xarray_input.py:126:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_plotly_utils/basevalidators.py:1395: in validate_coerce
self.raise_invalid_val(v)
_plotly_utils/basevalidators.py:308: in raise_invalid_val
v=repr(v),
/nix/store/qzqlix3rhk63zsmf05p1w14cx78rh96c-python3.12-xarray-2025.04.0/lib/python3.12/site-packages/xarray/core/common.py:184: in>
return formatting.array_repr(self)
/nix/store/q54d9qqlb27g2nf9ja4zsa89gl7b3yvm-python3-3.12.11/lib/python3.12/reprlib.py:21: in wrapper
result = user_function(self)
/nix/store/qzqlix3rhk63zsmf05p1w14cx78rh96c-python3.12-xarray-2025.04.0/lib/python3.12/site-packages/xarray/core/formatting.py:688>
data_repr = short_data_repr(arr)
/nix/store/qzqlix3rhk63zsmf05p1w14cx78rh96c-python3.12-xarray-2025.04.0/lib/python3.12/site-packages/xarray/core/formatting.py:657>
return limit_lines(repr(array.data), limit=40)
/nix/store/4xvvphpbvk5kkiqqnq3hflipbzb7ym2q-python3.12-numpy-2.3.0/lib/python3.12/site-packages/numpy/_core/arrayprint.py:1621: in>
extras.append(f"dtype={dtype_short_repr(arr.dtype)}")
/nix/store/4xvvphpbvk5kkiqqnq3hflipbzb7ym2q-python3.12-numpy-2.3.0/lib/python3.12/site-packages/numpy/_core/arrayprint.py:1574: in>
return f"'{str(dtype)}'"
/nix/store/4xvvphpbvk5kkiqqnq3hflipbzb7ym2q-python3.12-numpy-2.3.0/lib/python3.12/site-packages/numpy/__init__.py:852: in <module>
from . import exceptions
<frozen importlib._bootstrap>:1412: in _handle_fromlist
???
/nix/store/4xvvphpbvk5kkiqqnq3hflipbzb7ym2q-python3.12-numpy-2.3.0/lib/python3.12/site-packages/numpy/__init__.py:733: in __getatt>
import numpy.exceptions as exceptions
/nix/store/4xvvphpbvk5kkiqqnq3hflipbzb7ym2q-python3.12-numpy-2.3.0/lib/python3.12/site-packages/numpy/__init__.py:733: in __getatt>
import numpy.exceptions as exceptions
E RecursionError: maximum recursion depth exceeded
!!! Recursion detected (same locals & position)caused by the following code: """
Stand-alone module to provide information about whether optional deps exist.
"""
from importlib import import_module
import logging
import sys
logger = logging.getLogger(__name__)
_not_importable = set()
def get_module(name, should_load=True):
"""
Return module or None. Absolute import is required.
:param (str) name: Dot-separated module path. E.g., 'scipy.stats'.
:raise: (ImportError) Only when exc_msg is defined.
:return: (module|None) If import succeeds, the module will be returned.
"""
if not should_load:
return sys.modules.get(name, None)
if name not in _not_importable:
try:
return import_module(name)
except ImportError:
_not_importable.add(name)
except Exception:
_not_importable.add(name)
msg = f"Error importing optional module {name}"
logger.exception(msg)
return None |
13 tasks
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotly has been failing on darwin since the bump to 6.1.0.
If I should rebase this branch onto staging, please let me know. I'm also happy to split the version update into a separate PR if that helps get this one merged sooner.
Hydra: https://hydra.nixos.org/job/nixpkgs/trunk/python313Packages.plotly.aarch64-darwin
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.