mandelbulber: 2.32 -> 2.33, cleanup/add tests#417971
Merged
pbsds merged 2 commits intoNixOS:masterfrom Jun 24, 2025
Merged
Conversation
28 tasks
github-actions
bot
added
10.rebuild-darwin: 0
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Note: I originally marked this as fixing the build with GCC 14. That was wrong, the build was fixed sometime between 2025-04-24 and 2025-04-29 (but I'm not sure how). |
The package has a test suite, but it's run by just using the --test option on the main program. So I added it to passthru.tests. This required switching to finalAttrs (so I could use finalPackage).
mdaniels5757
changed the title
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: buddhi1980/mandelbulber2@2.32...2.33
Release notes: https://github.com/buddhi1980/mandelbulber2/releases/tag/2.33
Closes: #346115
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.