Skip to content

linuxPackages.rtw88: 0-unstable-2024-08-22 -> 0-unstable-2025-05-08#417954

Merged
pbsds merged 1 commit intoNixOS:masterfrom
mdaniels5757:update-rtw88
Jun 24, 2025
Merged

linuxPackages.rtw88: 0-unstable-2024-08-22 -> 0-unstable-2025-05-08#417954
pbsds merged 1 commit intoNixOS:masterfrom
mdaniels5757:update-rtw88

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Jun 18, 2025 •
edited
Loading

Changes: lwfinger/rtw88@764a1ee307...461b696b51

This should fix the gcc 14 build of linuxPackages_zen.rtw88. (Tracking: #388196 #356812)

I also added passthru.updateScript.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 18, 2025
@mdaniels5757 mdaniels5757 mentioned this pull request Jun 18, 2025
Open
28 tasks
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Jun 19, 2025

Not really sure what to do with these failures...

nixpkgs-review result for #417954

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 417954

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/15743402048

x86_64-linux (sandbox = true)

❌ 3 packages failed to build:
  • linuxKernel.packages.linux_5_10.rtw88
  • linuxPackages-libre.rtw88 (linuxKernel.packages.linux_libre.rtw88)
  • linuxPackages_lqx.rtw88 (linuxKernel.packages.linux_lqx.rtw88)
✅ 20 packages built:
  • linuxPackages_5_10_hardened.rtw88 (linuxKernel.packages.linux_5_10_hardened.rtw88)
  • linuxKernel.packages.linux_5_15.rtw88
  • linuxPackages_5_15_hardened.rtw88 (linuxKernel.packages.linux_5_15_hardened.rtw88)
  • linuxKernel.packages.linux_5_4.rtw88
  • linuxKernel.packages.linux_6_1.rtw88
  • linuxPackages.rtw88 (linuxKernel.packages.linux_6_12.rtw88)
  • linuxPackages_hardened.rtw88 (linuxPackages_6_12_hardened.rtw88)
  • linuxKernel.packages.linux_6_13.rtw88
  • linuxPackages_6_13_hardened.rtw88 (linuxKernel.packages.linux_6_13_hardened.rtw88)
  • linuxKernel.packages.linux_6_14.rtw88
  • linuxPackages_6_14_hardened.rtw88 (linuxKernel.packages.linux_6_14_hardened.rtw88)
  • linuxPackages_latest.rtw88 (linuxKernel.packages.linux_6_15.rtw88)
  • linuxPackages_6_1_hardened.rtw88 (linuxKernel.packages.linux_6_1_hardened.rtw88)
  • linuxKernel.packages.linux_6_6.rtw88
  • linuxPackages_6_6_hardened.rtw88 (linuxKernel.packages.linux_6_6_hardened.rtw88)
  • linuxPackages_ham.rtw88 (linuxKernel.packages.linux_ham.rtw88)
  • linuxPackages_latest-libre.rtw88 (linuxKernel.packages.linux_latest_libre.rtw88)
  • linuxPackages_xanmod.rtw88 (linuxKernel.packages.linux_xanmod.rtw88)
  • linuxPackages_xanmod_latest.rtw88 (linuxKernel.packages.linux_xanmod_latest.rtw88, linuxPackages_xanmod_stable.rtw88)
  • linuxPackages_zen.rtw88 (linuxKernel.packages.linux_zen.rtw88)

aarch64-linux (sandbox = true)

❌ 1 package failed to build:
  • linuxKernel.packages.linux_5_4.rtw88
✅ 18 packages built:
  • linuxKernel.packages.linux_5_10.rtw88
  • linuxPackages_5_10_hardened.rtw88 (linuxKernel.packages.linux_5_10_hardened.rtw88)
  • linuxKernel.packages.linux_5_15.rtw88
  • linuxPackages_5_15_hardened.rtw88 (linuxKernel.packages.linux_5_15_hardened.rtw88)
  • linuxKernel.packages.linux_6_1.rtw88
  • linuxPackages.rtw88 (linuxKernel.packages.linux_6_12.rtw88)
  • linuxPackages_hardened.rtw88 (linuxPackages_6_12_hardened.rtw88)
  • linuxKernel.packages.linux_6_13.rtw88
  • linuxPackages_6_13_hardened.rtw88 (linuxKernel.packages.linux_6_13_hardened.rtw88)
  • linuxKernel.packages.linux_6_14.rtw88
  • linuxPackages_6_14_hardened.rtw88 (linuxKernel.packages.linux_6_14_hardened.rtw88)
  • linuxPackages_latest.rtw88 (linuxKernel.packages.linux_6_15.rtw88)
  • linuxPackages_6_1_hardened.rtw88 (linuxKernel.packages.linux_6_1_hardened.rtw88)
  • linuxKernel.packages.linux_6_6.rtw88
  • linuxPackages_6_6_hardened.rtw88 (linuxKernel.packages.linux_6_6_hardened.rtw88)
  • linuxPackages_ham.rtw88 (linuxKernel.packages.linux_ham.rtw88)
  • linuxPackages_latest-libre.rtw88 (linuxKernel.packages.linux_latest_libre.rtw88)
  • linuxPackages-libre.rtw88 (linuxKernel.packages.linux_libre.rtw88)

@mdaniels5757 mdaniels5757 marked this pull request as ready for review June 19, 2025 03:30
@nix-owners nix-owners bot requested review from AtilaSaraiva and TvoroG June 19, 2025 03:31
@mdaniels5757 mdaniels5757 added backport release-25.05 0.kind: build failure A package fails to build 6.topic: kernel The Linux kernel 6.topic: hardware Drivers, Firmware and Kernels labels Jun 19, 2025
@pbsds
Copy link
Member

pbsds commented Jun 24, 2025

failures match hydra

https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.linuxKernel.packages.linux_5_10.rtw88.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.linuxPackages-libre.rtw88.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.linuxPackages_lqx.rtw88.x86_64-linux

https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.linuxKernel.packages.linux_5_4.rtw88.aarch64-linux

@pbsds
Copy link
Member

pbsds commented Jun 24, 2025

fixes https://hydra.nixos.org/build/300614364

@pbsds pbsds merged commit c082267 into NixOS:master Jun 24, 2025
36 of 37 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 24, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jun 24, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 24, 2025
@mdaniels5757 mdaniels5757 deleted the update-rtw88 branch June 24, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TvoroG TvoroG Awaiting requested review from TvoroG

@AtilaSaraiva AtilaSaraiva Awaiting requested review from AtilaSaraiva

Assignees

No one assigned

Labels

0.kind: build failure A package fails to build 6.topic: hardware Drivers, Firmware and Kernels 6.topic: kernel The Linux kernel 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdaniels5757 @pbsds