-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
vectorcode.chromadb: enable check phase #417811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2414fef
python3Packages.chromadb: improve doCheck condition
MattSturgeon 663fb4f
vectorcode: move installShellFiles to nativeBuildInputs
MattSturgeon f40c509
vectorcode: add python passthru
MattSturgeon 57c2c42
vectorcode: inherit `doCheck` from chromadb
MattSturgeon 3cf4c4b
vectorcode.chromadb: enable check phase
sarahec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test file is still present in the chroma's current
mainbranch: https://github.com/chroma-core/chroma/blob/main/chromadb/test/test_chroma.pyDoes that mean the concurrency issue also present on the base package?
Should I copy this to pkgs/development/python-modules/chromadb/default.nix ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've never seen the concurrency issue on the base package. It has to do with the way the tests were set up (and was fixed between 0.6.3 and now).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. Technically, these last two tests could be excluded on Darwin only.Just saw your note about the broken test on x86 linux also. How annoying.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reproduced the issue on x86_64-linux here: #417811 (comment)