workflow/labels: fix scheduled runs#417250
Merged
wolfgangwalther merged 4 commits intoNixOS:masterfrom Jun 16, 2025
Merged
Conversation
This would fail, because no previous workflow can be found.
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
This runs all PRs in scope to completion, before reporting errors.
Previously, the artifacts of different PRs would overwrite each other, thus leading to odd JSON parsing errors.
wolfgangwalther
force-pushed
the
ci-approvals-fix-2
branch
from
de2bc94 to
7efbed4
Compare
philiptaron
approved these changes
Jun 16, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
The code looks good. Each commit explains itself.
Contributor
Author
|
Found a way to add that error context, too. Annotations look like this:
(the logs have them in the right order, though) |
github-actions
bot
added
the
12.approvals: 1
MattSturgeon
approved these changes
Jun 16, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
Very clear, and very nice. Thanks!
wolfgangwalther
force-pushed
the
ci-approvals-fix-2
branch
from
ba505b4 to
51ee0d8
Compare
The original error is kept, but the PR number is printed as well. Makes debugging much easier.
wolfgangwalther
force-pushed
the
ci-approvals-fix-2
branch
from
51ee0d8 to
97130d0
Compare
github-actions
bot
added
12.approvals: 2
wolfgangwalther
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for a little bit of details, but most of that should be clear from the code and the discussion in #416808.
The job will now run all PRs to completion before reporting errors and it should report them nicely via GitHub annotations, too. The only I thing I don't really know is how to add more context to those errors. I.e., I'd like to add the PR number this failed for to it.
Things done
Will run another double check in my fork with this.
Add a 👍 reaction to pull requests you find important.