nixos-rebuild-ng: run nix build commands in temporary directory#417203
Closed
thiagokokada wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos-rebuild-ng: run nix build commands in temporary directory#417203thiagokokada wants to merge 1 commit intoNixOS:masterfrom
nix build commands in temporary directory#417203thiagokokada wants to merge 1 commit intoNixOS:masterfrom
Conversation
This is to avoid a nasty bug in `nix`, that together with another issue in `systemd-boot-builder.py` causes a broken generation to be created that causes further new activations to also be broken. Fix issue NixOS#144811.
Contributor
Author
|
CC @Mic92 @tejing1 @colemickens, this is an alternative for #417191. |
13 tasks
Contributor
|
Does this really handle things right if someone runs |
Contributor
Author
Fair, it doesn't. Thanks for giving an example, it is much easier to understand what you mean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid a nasty bug in
nix, that together with another issue insystemd-boot-builder.pycauses a broken generation to be created that causes further new activations to also be broken.Fix issue #144811.
Alternative for #417191.
Before:
After:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.