Skip to content

libpromhttp: drop#417072

Merged
pbsds merged 1 commit intoNixOS:masterfrom
mdaniels5757:drop-libpromhttp
Jun 17, 2025
Merged

libpromhttp: drop#417072
pbsds merged 1 commit intoNixOS:masterfrom
mdaniels5757:drop-libpromhttp

Conversation

@mdaniels5757
Copy link
Member

Unmaintained upstream, fails to build with gcc 14. Not dropping libprom because it's used by coturn

Tracking: #388196 #356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757 mdaniels5757 requested a review from cfsmp3 June 15, 2025 21:55
@mdaniels5757 mdaniels5757 added 8.has: clean-up This PR removes packages or removes other cruft backport release-25.05 labels Jun 15, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 15, 2025
@pbsds
Copy link
Member

pbsds commented Jun 17, 2025

Please add an entry into pkgs/top-level/aliases.nix

Unmaintained upstream, fails to build with gcc 14. Not dropping `libprom` because it's used by `coturn`
@mdaniels5757
Copy link
Member Author

Please add an entry into pkgs/top-level/aliases.nix

Done, sorry for forgetting!

@mdaniels5757 mdaniels5757 added the 0.kind: build failure A package fails to build label Jun 17, 2025
@pbsds pbsds merged commit 27ab9cd into NixOS:master Jun 17, 2025
15 of 17 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 17, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-417072-to-release-25.05 origin/release-25.05
cd .worktree/backport-417072-to-release-25.05
git switch --create backport-417072-to-release-25.05
git cherry-pick -x c191e958f2b40808b82d48be76c422c0bd864106

@mdaniels5757 mdaniels5757 deleted the drop-libpromhttp branch June 17, 2025 13:37
@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: build failure A package fails to build 8.has: clean-up This PR removes packages or removes other cruft 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants