Skip to content

which: add mdaniels5757 as maintainer, set updateScript, use finalAttrs#416757

Merged
drupol merged 3 commits intoNixOS:masterfrom
mdaniels5757:which
Jun 14, 2025
Merged

which: add mdaniels5757 as maintainer, set updateScript, use finalAttrs#416757
drupol merged 3 commits intoNixOS:masterfrom
mdaniels5757:which

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Jun 14, 2025

I was surprised this was unmaintained! So I'd like to adopt it. I also set updateScript, and switched to using finalAttrs instead of rec.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 14, 2025
@drupol drupol merged commit 41fad9f into NixOS:master Jun 14, 2025
14 of 17 checks passed
@drupol
Copy link
Contributor

drupol commented Jun 14, 2025

Thank you !

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 24, 2025

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants