Skip to content

Comments

wechat: init at 4.0.1.11#416642

Merged
wegank merged 1 commit intoNixOS:masterfrom
Prince213:push-wlslynyrxvzs
Jun 14, 2025
Merged

wechat: init at 4.0.1.11#416642
wegank merged 1 commit intoNixOS:masterfrom
Prince213:push-wlslynyrxvzs

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented Jun 14, 2025

Linux only for now but I'll soon add macOS support.

Resolves #354234.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@Prince213 Prince213 added the 8.has: package (new) This PR adds a new package label Jun 14, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 14, 2025
@Prince213 Prince213 force-pushed the push-wlslynyrxvzs branch from cd70089 to 86b915e Compare June 14, 2025 08:51
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

Tested on x86_64-linux.

No tons of error reported.

@Bot-wxt1221 Bot-wxt1221 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 14, 2025
Copy link
Contributor

@qbisi qbisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds/works on aarch64-linux.

@Prince213 Prince213 added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 14, 2025
@wegank
Copy link
Member

wegank commented Jun 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416642


x86_64-linux

✅ 1 package built:
  • wechat

@wegank wegank merged commit cb5a5d1 into NixOS:master Jun 14, 2025
14 of 18 checks passed
@Prince213
Copy link
Member Author

Thanks!

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 15, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 15, 2025
@Prince213 Prince213 deleted the push-wlslynyrxvzs branch June 27, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: WeChat

4 participants