Skip to content

python3Packages.python-wayland-extra: init at 0.7.0, python3Packages.streamcontroller-streamdeck: init at 0.1.5, Streamcontroller: 1.5.0-beta.8 -> 1.5.0-beta.12#416567

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
sifmelcara:streamcontroller-1-5-0-beta-11
Jan 2, 2026
Merged

Conversation

@sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Jun 14, 2025 •
edited
Loading

Fixes #416461

@ciferkey

Things done

Add 2 new python packages, which are new dependencies required by the new version of streamcontroller. streamcontroller_streamdeck is a fork of existing streamdeck package made by author of streamcontroller, required by the new version of streamcontroller.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@sifmelcara
Copy link
Member Author

sifmelcara commented Jun 14, 2025

Diff: StreamController/StreamController@1.5.0-beta.8...1.5.0-beta.11
Release notes: https://github.com/StreamController/StreamController/releases

@nix-owners nix-owners bot requested a review from natsukium June 14, 2025 01:06
sifmelcara
sifmelcara commented Jun 14, 2025
View reviewed changes
pkgs/development/python-modules/streamcontroller-streamdeck/default.nix
homepage = "https://github.com/StreamController/streamcontroller-python-elgato-streamdeck";
license = licenses.mit;
maintainers = with maintainers; [
majiir
Copy link
Member Author

@sifmelcara sifmelcara Jun 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majiir any thoughts on how we should handle this fork? would you mind to be listed as maintainers here?

Copy link
Contributor

@Majiir Majiir Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like both versions are being actively maintained, so I think the way you have handled it here is correct.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 14, 2025
@sifmelcara sifmelcara force-pushed the streamcontroller-1-5-0-beta-11 branch from 0ba3c90 to 73ba03b Compare June 14, 2025 01:46
keenanweaver
keenanweaver approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binding and actions work as expected.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416567
Commit: 73ba03b817c6d60bf6106dbbdd669c811b966583

x86_64-linux

✅ 9 packages built:
  • python312Packages.python-wayland-extra
  • python312Packages.python-wayland-extra.dist
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.python-wayland-extra
  • python313Packages.python-wayland-extra.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist
  • streamcontroller

@keenanweaver keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 17, 2025
@nixos-discourse
Copy link

nixos-discourse commented Jun 19, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5589

@nixos-discourse
Copy link

nixos-discourse commented Jun 24, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5604

@nixos-discourse
Copy link

nixos-discourse commented Jul 14, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5670

@keenanweaver
Copy link
Member

keenanweaver commented Jul 14, 2025

Looks like streamcontroller isn't building now.

nixpkgs-review result for #416567

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416567

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/16279442997

x86_64-linux

⏩ 1 package marked as broken and skipped:
  • streamcontroller
✅ 8 packages built:
  • python312Packages.python-wayland-extra
  • python312Packages.python-wayland-extra.dist
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.python-wayland-extra
  • python313Packages.python-wayland-extra.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist

aarch64-linux

⏩ 1 package marked as broken and skipped:
  • streamcontroller
✅ 8 packages built:
  • python312Packages.python-wayland-extra
  • python312Packages.python-wayland-extra.dist
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.python-wayland-extra
  • python313Packages.python-wayland-extra.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist

@sifmelcara
Copy link
Member Author

sifmelcara commented Jul 15, 2025

Sorry, it looks like yesterday one of our dependency (textual) got marked broken in master branch (see #425335). It's not obvious to me why the package was updated and proceed to get merged into master even though it breaks many downstream packages. Anyway, perhaps we need to wait for it to be fixed or review this PR on top of older commit

@andi242
Copy link

andi242 commented Jul 23, 2025

the breaking of textual also broke streamcontroller 1.5.0-beta.8 so we might really need this update to .11 with a fixed version textual.
unfortunately the unbreaking of the textual seems to be stale #425707 and just reverting tree-sitter packages to an earlier version, which would not be enough for streamcontroller, right?

beta.11 is not available, while beta.8 is preventing system builds and updating all other packages that need updates, so a bit of a lock up at least for my setup.
Switched to flatpak instead, which is a bummer, but at least it works.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 24, 2025
@sifmelcara sifmelcara force-pushed the streamcontroller-1-5-0-beta-11 branch from 73ba03b to 9a20e80 Compare July 26, 2025 22:18
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2025
keenanweaver
keenanweaver approved these changes Jul 26, 2025
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All functionality seemingly working, at least from what I've tested on x86_64-linux.

nixpkgs-review result for #416567

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416567

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/16544533428

x86_64-linux

✅ 9 packages built:
  • python312Packages.python-wayland-extra
  • python312Packages.python-wayland-extra.dist
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.python-wayland-extra
  • python313Packages.python-wayland-extra.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist
  • streamcontroller

aarch64-linux

✅ 9 packages built:
  • python312Packages.python-wayland-extra
  • python312Packages.python-wayland-extra.dist
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.python-wayland-extra
  • python313Packages.python-wayland-extra.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist
  • streamcontroller

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.streamcontroller-streamdeck
  • python312Packages.streamcontroller-streamdeck.dist
  • python313Packages.streamcontroller-streamdeck
  • python313Packages.streamcontroller-streamdeck.dist

@nixos-discourse
Copy link

nixos-discourse commented Jul 31, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5727

@simon-bueler
Copy link

simon-bueler commented Oct 10, 2025

Is this ready for merge? Waiting for this to use streamcontroller again on my machine.

@sifmelcara
Copy link
Member Author

sifmelcara commented Oct 10, 2025

Yes it is, I run this PR daily. We just need to find a person with nixpkgs commit permission to approve this.

I imagine people could be hesitate to merge this because the streamcontroller team forked some of their dependencies and we had to introduce them as new python packages in nixpkgs.

@pschmitt
Copy link
Contributor

pschmitt commented Oct 11, 2025

Been running it ever since as well, all good!

There's been a new release btw: https://github.com/StreamController/StreamController/releases/tag/1.5.0-beta.12

@nixos-discourse
Copy link

nixos-discourse commented Oct 14, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5946

SuperSandro2000
SuperSandro2000 requested changes Oct 15, 2025
View reviewed changes
@sifmelcara sifmelcara force-pushed the streamcontroller-1-5-0-beta-11 branch 2 times, most recently from dce446e to 88fce4f Compare October 16, 2025 22:23
@simon-bueler
Copy link

simon-bueler commented Dec 6, 2025

@SuperSandro2000 would be great if you find some time to review again

@sifmelcara sifmelcara mentioned this pull request Dec 10, 2025
Closed
3 tasks
@sifmelcara sifmelcara force-pushed the streamcontroller-1-5-0-beta-11 branch from 88fce4f to 4b35a43 Compare December 31, 2025 06:03
@sifmelcara sifmelcara changed the title python3Packages.python-wayland-extra: init at 0.7.0, python3Packages.streamcontroller-streamdeck: init at 0.1.5, Streamcontroller: 1.5.0-beta.8 -> 1.5.0-beta.11 python3Packages.python-wayland-extra: init at 0.7.0, python3Packages.streamcontroller-streamdeck: init at 0.1.5, Streamcontroller: 1.5.0-beta.8 -> 1.5.0-beta.12 Dec 31, 2025
@sifmelcara
Copy link
Member Author

sifmelcara commented Dec 31, 2025

Updated the version to 1.5.0-beta.12 and rebased to master

SuperSandro2000
SuperSandro2000 requested changes Jan 1, 2026
View reviewed changes
sifmelcara and others added 3 commits January 2, 2026 19:42
@sifmelcara @SuperSandro2000
python3Packages.python-wayland-extra: init at 0.7.0
04c2037 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@sifmelcara @SuperSandro2000
python3Packages.streamcontroller-streamdeck: init at 0.1.5
6e6773c 
It's a fork of streamdeck package made by streamcontroller author,
required by streamcontroller.

pkgs/development/python-modules/streamcontroller-streamdeck/default.nix
is copied from pkgs/development/python-modules/streamdeck/default.nix
with minor modification.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@sifmelcara
streamcontroller: 1.5.0-beta.8 -> 1.5.0-beta.12
1986d1b
@sifmelcara sifmelcara force-pushed the streamcontroller-1-5-0-beta-11 branch from 63d4dd9 to 1986d1b Compare January 2, 2026 11:46
@sifmelcara
Copy link
Member Author

sifmelcara commented Jan 2, 2026

Thank you! I have squashed the suggestions into commits and tested again to ensure the binary is still good

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Jan 2, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 2, 2026
Merged via the queue into NixOS:master with commit ec2c683 Jan 2, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@natsukium natsukium Awaiting requested review from natsukium

+2 more reviewers

@Majiir Majiir Majiir left review comments

@keenanweaver keenanweaver keenanweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Request: streamcontroller 1.5.0-beta.8 → 1.5.0-beta.11

8 participants

@sifmelcara @nixos-discourse @keenanweaver @andi242 @simon-bueler @pschmitt @Majiir @SuperSandro2000