Skip to content

coreutils: Skip tests that are flaky on ZFS-backed NFS filesystems#416474

Merged
ConnorBaker merged 1 commit intoNixOS:stagingfrom
tweag:jherland/coreutils-skip-flaky-tests
Sep 1, 2025
Merged

coreutils: Skip tests that are flaky on ZFS-backed NFS filesystems#416474
ConnorBaker merged 1 commit intoNixOS:stagingfrom
tweag:jherland/coreutils-skip-flaky-tests

Conversation

@jherland
Copy link
Contributor

@jherland jherland commented Jun 13, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from dasJ June 13, 2025 15:03
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 13, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jun 13, 2025

Re-running CI due to a odd failure fixed in #416448

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2025
@ConnorBaker ConnorBaker self-assigned this Aug 25, 2025
@ConnorBaker
Copy link
Contributor

ConnorBaker commented Aug 25, 2025

@jherland would you please rebase this to resolve conflicts and tag me when you think it's ready for review?

@jherland jherland force-pushed the jherland/coreutils-skip-flaky-tests branch from b086fdd to 428a513 Compare September 1, 2025 08:41
github-actions[bot]

This comment was marked as resolved.

Sign in to view

@jherland jherland force-pushed the jherland/coreutils-skip-flaky-tests branch from 428a513 to d242591 Compare September 1, 2025 08:44
@github-actions github-actions bot dismissed their stale review September 1, 2025 08:45

All good now, thank you!

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 1, 2025
@jherland
Copy link
Contributor Author

jherland commented Sep 1, 2025

@jherland would you please rebase this to resolve conflicts and tag me when you think it's ready for review?

@ConnorBaker ready for review now, I believe.

@ConnorBaker
Copy link
Contributor

ConnorBaker commented Sep 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416474 --package coreutils
Commit: d2425910a66db94122e943a8bb587dbaee20cfa5

x86_64-linux

✅ 3 packages built:
  • coreutils
  • coreutils.debug (coreutils.debug.debug, coreutils.debug.info)
  • coreutils.info (coreutils.info.debug, coreutils.info.info)

@ConnorBaker ConnorBaker merged commit 53a5c11 into NixOS:staging Sep 1, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ConnorBaker ConnorBaker ConnorBaker approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@dasJ dasJ Awaiting requested review from dasJ

Assignees

@ConnorBaker ConnorBaker

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jherland @wolfgangwalther @ConnorBaker @balsoft