python3Packages.wslink: init at 2.3.4

[qbisi]

python3Packages.wslink: Internal server side implementation of trame

python dependency of vtk/trame.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
• NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

Re-running CI due to a odd failure fixed in #416448

[natsukium]

How about using sourceRoot = "${src.name}/python" ?

[qbisi]

Looks good in this case. However setting sourceRoot to subdir will not always work when the setup.py script requires files out of the subdir. e.g. in python3Packages.fenics-dolfinx,

nixpkgs/pkgs/development/python-modules/fenics-dolfinx/default.nix

Lines 71 to 73 in fd48718

	preConfigure = ''
	cd python
	'';

pyproject wants to install a license file under ${src} out of ${src}/python,
https://github.com/FEniCS/dolfinx/blob/3be58ec98d266dcae6d57e16c725fa3328dd20d2/python/pyproject.toml#L61
thus setting sourceRoot = "${src.name}/python" will fail the build of python3Packages.fenics-dolfinx.

[ethancedwards8]

May want to add a comment noting this

[qbisi]

Another concern about setting souce root via "${src.name}/python" is about the unpacked tarball source.

For example :

  src = fetchurl {
    url = "https://github.com/Kitware/wslink/archive/refs/tags/v2.3.4.tar.gz";
    hash = "sha256-SybJvGZaVxvd57BWW3D4VQ/bHUB8Da0yEaPWS35CO+E=";
  };
  
  sourceRoot = "${src.name}/python";

  # add missing version string to dist-info
  postPatch = ''
    sed -i "/name *= */a\    version='${version}'," setup.py
  '';  

will set sourceRoot = "v2.3.4.tar.gz/python" and result in build failure.

[qbisi]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416458

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/15695692004

---

x86_64-linux (sandbox = true)

✅ 4 packages built:

• python312Packages.wslink
• python312Packages.wslink.dist
• python313Packages.wslink
• python313Packages.wslink.dist

---

aarch64-linux (sandbox = true)

✅ 4 packages built:

• python312Packages.wslink
• python312Packages.wslink.dist
• python313Packages.wslink
• python313Packages.wslink.dist

---

x86_64-darwin (sandbox = true)

✅ 4 packages built:

• python312Packages.wslink
• python312Packages.wslink.dist
• python313Packages.wslink
• python313Packages.wslink.dist

---

aarch64-darwin (sandbox = true)

✅ 4 packages built:

• python312Packages.wslink
• python312Packages.wslink.dist
• python313Packages.wslink
• python313Packages.wslink.dist