Skip to content

python3Packages.onnxruntime: mark as broken on aarch64-linux#416434

Closed
GaetanLepage wants to merge 2 commits intoNixOS:masterfrom
GaetanLepage:onnxruntime
Closed

python3Packages.onnxruntime: mark as broken on aarch64-linux#416434
GaetanLepage wants to merge 2 commits intoNixOS:masterfrom
GaetanLepage:onnxruntime

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jun 13, 2025

Things done

Several downstream packages crash when using python3Packages.onnxruntime on aarch64-linux.
I propose to disable it on this platform.

cc @ck3d @puffnfresh @cbourjau

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 13, 2025
@wolfgangwalther
Copy link
Contributor

Re-running CI due to a odd failure fixed in #416448

@NickCao
Copy link
Member

NickCao commented Jun 13, 2025

Can't seem to reproduce the failure importing onnxruntime manually.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Jun 13, 2025

Can't seem to reproduce the failure importing onnxruntime manually.

Can you try building #416102 on ARM please?

@NickCao
Copy link
Member

NickCao commented Jun 13, 2025

Can't seem to reproduce the failure importing onnxruntime manually.

Can you try building #416102 on ARM please?

I can reproduce the issue building vectorcode, but not with importing onnxruntime manually, or building vectorcode with sandbox disabled.

@NickCao
Copy link
Member

NickCao commented Jun 13, 2025

       > Error in cpuinfo: failed to parse the list of possible processors in /sys/devices/system/cpu/possible
       > Error in cpuinfo: failed to parse the list of present processors in /sys/devices/system/cpu/present
       > Error in cpuinfo: failed to parse both lists of possible and present processors
       > terminate called after throwing an instance of 'onnxruntime::OnnxRuntimeException'
       >   what():  /build/source/include/onnxruntime/core/common/logging/logging.h:371 static const onnxruntime::logging::Logger& onnxruntime::logging::LoggingManager::DefaultLogger() Attempt to use DefaultLogger but none has been registered.
       >

@NickCao
Copy link
Member

NickCao commented Jun 14, 2025

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 15, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 18, 2025
@sarahec
Copy link
Contributor

sarahec commented Jun 20, 2025

And microsoft/onnxruntime#15650 Fix in https://github.com/microsoft/onnxruntime/pull/15661/files

@NickCao are you sure? That fixes a logging error.

microsoft/onnxruntime#10038 (comment) seems to be relevant to our issue.

@NickCao
Copy link
Member

NickCao commented Jun 20, 2025

And microsoft/onnxruntime#15650 Fix in https://github.com/microsoft/onnxruntime/pull/15661/files

@NickCao are you sure? That fixes a logging error.

microsoft/onnxruntime#10038 (comment) seems to be relevant to our issue.

I'm pretty sure. This is about one bug triggering another: 1. libcpuinfo initialization fails within the nix sandbox on aarch64-linux 2. the warning/error log is written to an uninitialized logger, causing a crash. Fixing either of this would prevent it from crashing.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 21, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 21, 2025
@GaetanLepage
Copy link
Contributor Author

The initial motivation for this PR (vectorcode failing to build on aarch64-linux) has been dealt with in #417811.

@GaetanLepage GaetanLepage deleted the onnxruntime branch June 24, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants