pkgs/buffybox: split into unl0kr and buffyboard#416430
Closed
hustlerone wants to merge 1 commit intoNixOS:masterfrom
Closed
pkgs/buffybox: split into unl0kr and buffyboard#416430hustlerone wants to merge 1 commit intoNixOS:masterfrom
hustlerone wants to merge 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
I feel like there's too much duplicated code, especially since both have the same dependencies and it's all decided by a flag |
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
|
Re-running CI due to a odd failure fixed in #416448 |
Contributor
Author
|
@uninsane forgot to ping |
Contributor
Author
|
This PR is gonna be counterproductive given that f0rmz is now also a thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits buffybox into unl0kr and buffyboard
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.