zfs_2_2: 2.2.7 -> 2.2.8#416236
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
adamcstephens
force-pushed
the
push-pmnlmlwqwqlo
branch
from
a2a5c77 to
06743bb
Compare
amarshall
left a comment
amarshall
left a comment
There was a problem hiding this comment.
Successfully built and ran tests on x86_64-linux
| "--version-regex=^zfs-(${lib.versions.major version}\\.${lib.versions.minor version}\\.[0-9]+)" | ||
| "--override-filename=pkgs/os-specific/linux/zfs/${lib.versions.major version}_${lib.versions.minor version}.nix" | ||
| ]; | ||
| }; |
| // lib.optionalAttrs (kernelModuleAttribute != "zfs_unstable") { | ||
| updateScript = nix-update-script { | ||
| extraArgs = [ | ||
| "--version-regex=^zfs-(${lib.versions.major version}\\.${lib.versions.minor version}\\.[0-9]+)" |
There was a problem hiding this comment.
ZFS often has a x.y.99 tag that is mutable and not an actual release—can we skip that somehow? Something not-great-but-probably-fine like [0-8]?[0-9] perhaps? But I think that nix-update actually only uses GitHub releases, not tags, so it doesn’t matter.
There was a problem hiding this comment.
I think it can/does use tags as well. Looking through the previous tags, I'm not sure if this will be a problem in practice. Upstream seems to tag x.x.99 during the RC cycle, for whatever reason, and since this logic is pinned to only stable releases and matching versions, I don't suspect problems. I suggest we merge as-is, and if the bot messes up a PR we can address then. Thoughts?
There was a problem hiding this comment.
Also as a singular data point, I used this updater to do the update, and it did not pick up the older 2.2.99. I think nix-update only fetches a page or two of releases/tags, and favors newest by time anyway.
There was a problem hiding this comment.
Yea I think it should be fine, bringing it up to at least discuss it and validate 🙂
wegank
added
the
12.approvals: 1
amarshall
added
12.approved-by: package-maintainer
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
4 participants
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.