You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added lib.attrsets.attrsToListRecursive and lib.attrsets.attrsToListRecursive' and their aliases in root. For further details please check corresponding docstrings.
This approach was used in the module system for processing the options and it causes unnecessary strictness (worse performance, more errors).
So accepting this runs a risk of making the wrong thing easier.
If we do accept it, which I don't think I would recommend, the function(s) could probably be generalized a bit, and be made to look more like the *With functions we already have, where we take a function to determine the boundary of the recursive structure. The argument (x: x == { }) would then make it behave like attrsToListRecursive' as currently specified in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
lib.attrsets.attrsToListRecursiveandlib.attrsets.attrsToListRecursive'and their aliases in root. For further details please check corresponding docstrings.Add a 👍 reaction to pull requests you find important.