Skip to content

python3Packages.uamqp: drop#415985

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
mdaniels5757:drop-uamqp
Jun 12, 2025
Merged

python3Packages.uamqp: drop#415985
Aleksanaa merged 1 commit intoNixOS:masterfrom
mdaniels5757:drop-uamqp

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Jun 11, 2025

Deprecated by upstream and broken.

Tracking: #388196 #356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

Deprecated and broken.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 11, 2025
@nix-owners nix-owners bot requested a review from natsukium June 11, 2025 23:06
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 11, 2025
@mdaniels5757
Copy link
Member Author

Cc maintainer: @mwilsoncoding

types-enum34 = throw "types-enum34 is obselete since Python 3.4"; # added 2025-02-15
types-paramiko = throw "types-paramiko has been removed because it was unused."; # added 2022-05-30
types-typed-ast = throw "types-typed-ast was removed because so was typed-ast"; # added 2025-05-24
uamqp = throw "'uamqp' has been removed because it is broken and unmaintained."; # added 2025-06-11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unmaintained? It had a commit two days ago.
Maybe you should open an upstream issue about GCC 14.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. It is in fact unmaintained and I doubt they would fix any issues.

@dotlambda
Copy link
Member

Deprecated by upstream

Not yet:

This repo is no longer in active maintenance and we plan on deprecating it sometime in the first quarter of 2025.

types-enum34 = throw "types-enum34 is obselete since Python 3.4"; # added 2025-02-15
types-paramiko = throw "types-paramiko has been removed because it was unused."; # added 2022-05-30
types-typed-ast = throw "types-typed-ast was removed because so was typed-ast"; # added 2025-05-24
uamqp = throw "'uamqp' has been removed because it is broken and unmaintained."; # added 2025-06-11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. It is in fact unmaintained and I doubt they would fix any issues.

@Aleksanaa Aleksanaa merged commit 123b18a into NixOS:master Jun 12, 2025
17 of 20 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 12, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-415985-to-release-25.05 origin/release-25.05
cd .worktree/backport-415985-to-release-25.05
git switch --create backport-415985-to-release-25.05
git cherry-pick -x 428b63d4ace52e07d0dee3747a1d9dfa759bc064

@mdaniels5757 mdaniels5757 deleted the drop-uamqp branch June 12, 2025 03:51
@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants