Skip to content

lm_sensors: 3.6.0 -> 3.6.2#415786

Merged
peterhoeg merged 1 commit intoNixOS:masterfrom
peterhoeg:f/sensors2
Jun 15, 2025
Merged

lm_sensors: 3.6.0 -> 3.6.2#415786
peterhoeg merged 1 commit intoNixOS:masterfrom
peterhoeg:f/sensors2

Conversation

@peterhoeg
Copy link
Member

Current upstream is effectly dead (no activity since 2020), but openSUSE is actively maintaining a fork that gentoo also uses.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@peterhoeg peterhoeg requested a review from oxalica June 11, 2025 08:13
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jun 11, 2025
@nix-owners nix-owners bot requested a review from pmeiyu June 11, 2025 08:18
@oxalica
Copy link
Contributor

oxalica commented Jun 11, 2025

openSUSE is actively maintaining a fork that gentoo also uses.

Source1: https://build.opensuse.org/projects/Base:System/packages/sensors/files/sensors.spec
Source2: https://packages.gentoo.org/packages/sys-apps/lm-sensors

Copy link
Contributor

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the upstream switch. Builds and works for me.

Just a few nits.

Comment on lines 66 to 67
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ${toString stdenv.hostPlatform.isStatic} work? The only difference is that toString false == "". Not sure if it breaks stuff.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While verbose, it's very clear what is going on so I favour this way of doing it for readability's sake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to call it "openSUSE fork"? I'm not sure if @hramrach is doing it on behalf of OpenSUSE, or as a personal fork that is used by distros.

Copy link
Member Author

@peterhoeg peterhoeg Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that it is in his capacity as a suse employee, but we can of course also just drop that bit here. We don't really gain anything by leaving it in here.

@peterhoeg peterhoeg force-pushed the f/sensors2 branch 2 times, most recently from d38db4f to 4283230 Compare June 13, 2025 09:42
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 13, 2025
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 13, 2025
@wolfgangwalther
Copy link
Contributor

Re-running CI due to a odd failure fixed in #416448

Copy link
Contributor

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@peterhoeg peterhoeg merged commit c2f6cd0 into NixOS:master Jun 15, 2025
25 of 27 checks passed
@peterhoeg peterhoeg deleted the f/sensors2 branch June 15, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants