Conversation
Source1: https://build.opensuse.org/projects/Base:System/packages/sensors/files/sensors.spec |
oxalica
left a comment
There was a problem hiding this comment.
👍 on the upstream switch. Builds and works for me.
Just a few nits.
There was a problem hiding this comment.
Does ${toString stdenv.hostPlatform.isStatic} work? The only difference is that toString false == "". Not sure if it breaks stuff.1
There was a problem hiding this comment.
While verbose, it's very clear what is going on so I favour this way of doing it for readability's sake.
There was a problem hiding this comment.
Is it okay to call it "openSUSE fork"? I'm not sure if @hramrach is doing it on behalf of OpenSUSE, or as a personal fork that is used by distros.
There was a problem hiding this comment.
My understanding is that it is in his capacity as a suse employee, but we can of course also just drop that bit here. We don't really gain anything by leaving it in here.
d38db4f to
4283230
Compare
|
Re-running CI due to a odd failure fixed in #416448 |
Current upstream is effectly dead (no activity since 2020), but openSUSE is actively maintaining a fork that gentoo also uses.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.