Skip to content

apacheHttpdPackages_2_4.mod_timestamp: fix build with gcc 14#415590

Merged
pbsds merged 1 commit intoNixOS:masterfrom
mdaniels5757:fix-mod_timestamp-build
Jun 17, 2025
Merged

apacheHttpdPackages_2_4.mod_timestamp: fix build with gcc 14#415590
pbsds merged 1 commit intoNixOS:masterfrom
mdaniels5757:fix-mod_timestamp-build

Conversation

@mdaniels5757
Copy link
Member

One note: even though the commit is merged upstream already, I had to download it and add it to the tree. This is because, although https://source.redwax.eu/projects/RS/repos/mod_timestamp/commits/5f9d4458f05c5d9f4b416de867fd9327aba865d5 works fine, https://source.redwax.eu/projects/RS/repos/mod_timestamp/commits/5f9d4458f05c5d9f4b416de867fd9327aba865d5/raw requires a login.

Tracking: #388196 #356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 10, 2025
@nix-owners nix-owners bot requested a review from dirkx June 10, 2025 14:24
Copy link
Contributor

@dirkx dirkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. Thanks!

@mdaniels5757
Copy link
Member Author

Builds on all platforms:

nixpkgs-review result for #415590

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 415590

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/15562506830

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-415590-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/1nncnzi11ahgllv3g2qwxmygdalb9lxp-mod_timestamp-0.2.3
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-415590-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/4wflh0dn2rg52qs1l0kcinw8krnbgv3l-mod_timestamp-0.2.3
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-415590-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/6ydns7cvy3z7g4g5mgvlc9pxd0cv0i7q-mod_timestamp-0.2.3
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-415590-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/yyslq1rbqm3hsywbzlxignh6ra6mvq8i-mod_timestamp-0.2.3

x86_64-linux (sandbox = true)

✅ 1 package built:
  • apacheHttpdPackages.mod_timestamp (apacheHttpdPackages_2_4.mod_timestamp)

aarch64-linux (sandbox = true)

✅ 1 package built:
  • apacheHttpdPackages.mod_timestamp (apacheHttpdPackages_2_4.mod_timestamp)

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • apacheHttpdPackages.mod_timestamp (apacheHttpdPackages_2_4.mod_timestamp)

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • apacheHttpdPackages.mod_timestamp (apacheHttpdPackages_2_4.mod_timestamp)

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 11, 2025
@pbsds pbsds merged commit 8940949 into NixOS:master Jun 17, 2025
20 of 21 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 17, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 17, 2025
@mdaniels5757 mdaniels5757 deleted the fix-mod_timestamp-build branch June 17, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants