treewide: remove primeos from maintainers#415587
Conversation
|
I'm working on automating that btw: NixOS/nixpkgs-committers#62 :) |
|
Yeah I am no longer responsible for the script. |
6d4c84f to
cf071c7
Compare
|
Thanks @phanirithvij. I think that should be the all of it. |
cf071c7 to
6297a95
Compare
|
It's been a while already, as there was no response or objections I intend to merge it soon. |
Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
6297a95 to
e8427c7
Compare
If he's removed from all packages, then this entry should be removed as well. |
|
We can do that in a separate PR, commiter delegation team hasn't removed him from nixpkgs-committers team yet, so I am not sure if we should do it here. |
|
I don't think the two are related. Our contribution guidelines ask new maintainers to add themselves in the PR where they become maintainer of a package.. because we don't want stray maintainer entries in |
|
That's fair I suppose. I kind of had a thought that those in the Nixpkgs-committer should be in the Nixpkgs-maintainer team too. |
These packages were previously maintained by primeos who became inactive and was removed in NixOS#415587, leaving some packages without a maintainer. I'm taking over maintenance for these packages that I'm interested in: - swayidle - swaylock - wayland-utils - wev - wlsunset - wayland-protocols
These packages were previously maintained by primeos who became inactive and was removed in #415587, leaving some packages without a maintainer. I'm taking over maintenance for these packages that I'm interested in: - swayidle - swaylock - wayland-utils - wev - wlsunset - wayland-protocols
This removes primeos from all nixos modules and packages maintainer entries. Having an inactive maintainer entry there is misleading and paints a false picture that the package/module is still being maintained. This leads to scenarios like #412462, #372789, #415345 that end up being unaddressed.
Package maintainers are expected to address bug reports and perform maintainence which hasn't been taken up by him for long.
In addition, I would also like @NixOS/commit-bit-delegation team to invoke RFC 55 (#88867) to remove @primeos's commit access as they haven't commited to Nixpkgs for more than a year, except 10cbea2, which removed him from maintainers of few modules.
This, by no means, is belittling @primeos's contributions over the past few years (back when he was still active). He is free to request his commit bit back and restore maintainership once he becomes active again.
His entry in
maintainers-list.nixhasn't been removed yet, that can be done if desired.His commit history on nixpkgs for reference: https://github.com/NixOS/nixpkgs/commits?author=primeos
CC NixOS/nixpkgs-committers#50
CC #88867