Skip to content

treewide: remove primeos from maintainers#415587

Merged
JohnRTitor merged 2 commits intoNixOS:masterfrom
JohnRTitor:remove-primeos-from-maintainers
Jul 5, 2025
Merged

treewide: remove primeos from maintainers#415587
JohnRTitor merged 2 commits intoNixOS:masterfrom
JohnRTitor:remove-primeos-from-maintainers

Conversation

@JohnRTitor
Copy link
Member

@JohnRTitor JohnRTitor commented Jun 10, 2025

This removes primeos from all nixos modules and packages maintainer entries. Having an inactive maintainer entry there is misleading and paints a false picture that the package/module is still being maintained. This leads to scenarios like #412462, #372789, #415345 that end up being unaddressed.
Package maintainers are expected to address bug reports and perform maintainence which hasn't been taken up by him for long.

In addition, I would also like @NixOS/commit-bit-delegation team to invoke RFC 55 (#88867) to remove @primeos's commit access as they haven't commited to Nixpkgs for more than a year, except 10cbea2, which removed him from maintainers of few modules.

This, by no means, is belittling @primeos's contributions over the past few years (back when he was still active). He is free to request his commit bit back and restore maintainership once he becomes active again.

His entry in maintainers-list.nix hasn't been removed yet, that can be done if desired.

His commit history on nixpkgs for reference: https://github.com/NixOS/nixpkgs/commits?author=primeos

CC NixOS/nixpkgs-committers#50
CC #88867

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 10, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 10, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 11, 2025
@Aleksanaa
Copy link
Member

In addition, I would also like @NixOS/commit-bit-delegation team to invoke RFC 55 (#88867) to remove @primeos's commit access as they haven't commited to Nixpkgs for more than a year, except 10cbea2, which removed him from maintainers of few modules.

This will happen in the next year. See #88867

@Aleksanaa Aleksanaa requested a review from primeos June 12, 2025 02:53
@JohnRTitor JohnRTitor requested a review from phaer June 12, 2025 16:44
@JohnRTitor
Copy link
Member Author

This will happen in the next year. See #88867

I guess @Mic92 tends to run the script once a year usually in the month of January and takes care of it then.
But since we are doing this PR anyway, it wouldn't hurt removing commit access from an inactive account. Though it's not my call to make.

@infinisil
Copy link
Member

I'm working on automating that btw: NixOS/nixpkgs-committers#62 :)

@Mic92
Copy link
Member

Mic92 commented Jun 13, 2025

Yeah I am no longer responsible for the script.

Copy link
Member

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed pkgs/by-name/in/iniparser/package.nix

see if other occurances of primeos can be removed as well rg -i primeos

@JohnRTitor JohnRTitor force-pushed the remove-primeos-from-maintainers branch from 6d4c84f to cf071c7 Compare June 15, 2025 18:52
@JohnRTitor
Copy link
Member Author

Thanks @phanirithvij. I think that should be the all of it.

@github-actions github-actions bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 15, 2025
@JohnRTitor JohnRTitor force-pushed the remove-primeos-from-maintainers branch from cf071c7 to 6297a95 Compare June 21, 2025 21:34
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 24, 2025
@JohnRTitor
Copy link
Member Author

It's been a while already, as there was no response or objections I intend to merge it soon.

Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
@JohnRTitor JohnRTitor force-pushed the remove-primeos-from-maintainers branch from 6297a95 to e8427c7 Compare July 3, 2025 14:57
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 3, 2025
@wolfgangwalther
Copy link
Contributor

His entry in maintainers-list.nix hasn't been removed yet, that can be done if desired.

If he's removed from all packages, then this entry should be removed as well.

@JohnRTitor
Copy link
Member Author

We can do that in a separate PR, commiter delegation team hasn't removed him from nixpkgs-committers team yet, so I am not sure if we should do it here.

@wolfgangwalther
Copy link
Contributor

I don't think the two are related. Our contribution guidelines ask new maintainers to add themselves in the PR where they become maintainer of a package.. because we don't want stray maintainer entries in maintainer-list.nix. So we should do the opposite on removal as well.

@JohnRTitor
Copy link
Member Author

JohnRTitor commented Jul 4, 2025

That's fair I suppose.

I kind of had a thought that those in the Nixpkgs-committer should be in the Nixpkgs-maintainer team too.

@nixpkgs-ci nixpkgs-ci bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 5, 2025
@JohnRTitor JohnRTitor merged commit 6f4745b into NixOS:master Jul 5, 2025
25 of 28 checks passed
@JohnRTitor JohnRTitor deleted the remove-primeos-from-maintainers branch July 5, 2025 18:30
wineee added a commit to wineee/nixpkgs that referenced this pull request Jul 22, 2025
These packages were previously maintained by primeos who became inactive
and was removed in NixOS#415587, leaving some packages without a maintainer.

I'm taking over maintenance for these packages that I'm interested in:
  - swayidle
  - swaylock
  - wayland-utils
  - wev
  - wlsunset
  - wayland-protocols
JohnRTitor pushed a commit that referenced this pull request Jul 22, 2025
These packages were previously maintained by primeos who became inactive
and was removed in #415587, leaving some packages without a maintainer.

I'm taking over maintenance for these packages that I'm interested in:
  - swayidle
  - swaylock
  - wayland-utils
  - wev
  - wlsunset
  - wayland-protocols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants