ci/nixpkgs-vet: add badFiles and conflictingPaths checks#415551
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Jun 10, 2025
Merged
ci/nixpkgs-vet: add badFiles and conflictingPaths checks#415551wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
philiptaron,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
Jun 10, 2025
Those checks are part of top-level/nixpkgs-basic-release-checks.nix, but can be run in CI already to prevent regressions. The idea is to upstream them into nixpkgs-vet eventually, but we can just as well run them as-is in the same derivation already.
wolfgangwalther
force-pushed
the
ci-nixpkgs-vet-release-checks
branch
from
d70b12d to
247d562
Compare
Contributor
Author
|
Added the issue references as comments, too. |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
1 task
Aleksanaa
reviewed
Jun 10, 2025
Contributor
|
@wolfgangwalther would you like to join the @NixOS/nixpkgs-vet team? I'd appreciate both your CRs and thoughtful feedback. |
Contributor
Author
Sure, count me in. I'm happy to give feedback. |
2 tasks
Contributor
I filed NixOS/org#123 to accomplish this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those checks are part of
top-level/nixpkgs-basic-release-checks.nix, but can be run in CI already to prevent regressions. The idea is to upstream them into nixpkgs-vet eventually, but we can just as well run them as-is in the same derivation already.This slices another small piece off of #406825 to reduce scope. @philiptaron volunteered to upstream those into nixpkgs-vet later, thank you!
Things done
Add a 👍 reaction to pull requests you find important.