Skip to content

p4est: 0-unstable-2021-06-22 -> 2.8.7 #415439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

p4est: 0-unstable-2021-06-22 -> 2.8.7 #415439

merged 2 commits into from
Jul 24, 2025

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Jun 9, 2025 •
edited
Loading

p4est: Parallel Adaptive Mesh Refinement (AMR) library on Forests of Octrees

p4est is used by downstream dealii and petsc.
This package has been outdated for a while. Hence a rewrite and migration to pkgs/by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 9, 2025
@nix-owners nix-owners bot requested a review from cburstedde June 9, 2025 23:06
nicoonoclaste
nicoonoclaste approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@nicoonoclaste nicoonoclaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the cleanup. The new derivations look fine ❤️

@nicoonoclaste nicoonoclaste added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 10, 2025
@nicoonoclaste
Copy link
Contributor

nicoonoclaste commented Jun 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 415439
Commit: 4339538dde8b24ec093266590e1b746e9d717169

x86_64-linux

✅ 4 packages built:
  • libsc
  • libsc-dbg
  • p4est
  • p4est-dbg

@qbisi
Copy link
Contributor Author

qbisi commented Jun 10, 2025

I am not the original package maintainer nor the upstream develop of p4est. cc Prof. @cburstedde, what do you think of this migration.

@qbisi qbisi removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jun 10, 2025
@qbisi qbisi mentioned this pull request Jul 4, 2025
Merged
13 tasks
@cburstedde
Copy link
Contributor

cburstedde commented Jul 7, 2025

I don't know enough about the current conventions of nix packages to say. In generally I'd say the update is fine.

About the package name, in Debian libsc is called p4est-sc, and this would be the same in the next release I'd think. Would it make sense to contact the Debian maintainer and agree on one name of the sc library, whatever it will be?

@qbisi
Copy link
Contributor Author

qbisi commented Jul 7, 2025

I did not notice that there was a p4est-sc lib in debian by searching repology. The name libsc was borrowed from the github repo and gentoo package libsc.
I will keep the orginal name p4est-sc in sync with debian. This also avoid renaming petsc-sc to libsc which might cause confusion.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 9, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 10, 2025
NickCao
NickCao reviewed Jul 23, 2025
View reviewed changes
@qbisi
Copy link
Contributor Author

qbisi commented Jul 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 415439

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/16485223789

x86_64-linux

✅ 4 packages built:
  • p4est
  • p4est-dbg
  • p4est-sc
  • p4est-sc-dbg

aarch64-linux

✅ 4 packages built:
  • p4est
  • p4est-dbg
  • p4est-sc
  • p4est-sc-dbg

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • p4est
  • p4est-dbg
  • p4est-sc
  • p4est-sc-dbg

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • p4est
  • p4est-dbg
  • p4est-sc
  • p4est-sc-dbg

@NickCao NickCao merged commit b5a820d into NixOS:master Jul 24, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao left review comments

@nicoonoclaste nicoonoclaste nicoonoclaste approved these changes

@cburstedde cburstedde Awaiting requested review from cburstedde

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qbisi @nicoonoclaste @cburstedde @NickCao