Skip to content

ayatana-indicator-datetime: 24.5.1 -> 25.4.0, init lomiri-indicator-datetime#415356

Merged
OPNA2608 merged 3 commits intoNixOS:masterfrom
OPNA2608:update/ayatana-indicator-datetime
Jun 17, 2025
Merged

ayatana-indicator-datetime: 24.5.1 -> 25.4.0, init lomiri-indicator-datetime#415356
OPNA2608 merged 3 commits intoNixOS:masterfrom
OPNA2608:update/ayatana-indicator-datetime

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jun 9, 2025

https://github.com/AyatanaIndicators/ayatana-indicator-datetime/blob/25.4.0/ChangeLog

There is enough divergence between with-lomiri-features and without-lomiri-features now that adding an option to enable them and defaulting to false (to preserve current behaviour for non-Lomiri usecases) made sense to me.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Turning off Lomiri features in this derivation, because it now results in a different indicator.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 9, 2025
ayatana-indicator-datetime, overridden to enable Lomiri features.
@OPNA2608 OPNA2608 force-pushed the update/ayatana-indicator-datetime branch from c773270 to 1a6b286 Compare June 13, 2025 11:49
@wolfgangwalther
Copy link
Contributor

Re-running CI due to a odd failure fixed in #416448

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jun 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 415356
Commit: bf0458a311b0aa492c3bc4d3c72b148f9fb1af6b


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 7 packages built:
  • ayatana-indicator-datetime
  • lomiri.lomiri
  • lomiri.lomiri-indicator-datetime
  • lomiri.lomiri-session
  • lomiri.lomiri-system-settings
  • lomiri.lomiri-system-settings-unwrapped
  • lomiri.lomiri-system-settings-unwrapped.dev

I can't replicate the nixosTests.lomiri.keymap from x86_64-linux OfBorg, all .passthru.tests pass on my end. Thinking there might be some flakiness, either with the keymap switching keybind not getting caught, or it not being applied yet when we attempt to check it. Something that could be improved.

Will not bother with replicating & debugging test failures from aarch64-linux OfBorg, the runner is likely just too weak to complete things in a timely manner.

@OPNA2608 OPNA2608 merged commit 5d44e71 into NixOS:master Jun 17, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants