Skip to content

socklog: 2.1.0 -> 2.1.1#414979

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
petrzjunior:socklog
Jun 27, 2025
Merged

socklog: 2.1.0 -> 2.1.1#414979
wolfgangwalther merged 1 commit intoNixOS:masterfrom
petrzjunior:socklog

Conversation

@petrzjunior
Copy link
Contributor

@petrzjunior petrzjunior commented Jun 8, 2025

Upgrade socklog to 2.1.1. This fixes build on GCC 14.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 8, 2025
@nix-owners nix-owners bot requested a review from joachifm June 8, 2025 10:50
@petrzjunior
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 414979

Logs: https://github.com/petrzjunior/nixpkgs-review-gha/actions/runs/15517648295


x86_64-linux (sandbox = true)

✅ 3 packages built:
  • socklog
  • socklog.doc
  • socklog.man

aarch64-linux (sandbox = true)

✅ 3 packages built:
  • socklog
  • socklog.doc
  • socklog.man

x86_64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • socklog
  • socklog.doc
  • socklog.man

Error logs: `x86_64-darwin`
socklog
   28 |   byte_copy((char *)&sa.sin_addr, 4, ip);
      |            ^
2 warnings generated.
./load check-socklog-inet unix.a byte.a `cat socket.lib`
ld: warning: option -s is obsolete and being ignored
./check-local socklog socklog-check socklog-conf tryto uncat
Checking socklog...
listening on socklog.check.socket, starting.
foo
0
socklog: fatal: bind(): permission denied
fatal: unable to bind socket: permission denied
/private/tmp/nix-build-socklog-2.1.1.drv-0/admin/socklog-2.1.1/compile/socklog.check: line 18: kill: (9460) - No such process
0
U: foo
U: bar
U: baz
0
socklog failed.
make: *** [Makefile:6: check] Error 1

aarch64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • socklog
  • socklog.doc
  • socklog.man

Error logs: `aarch64-darwin`
socklog
   28 |   byte_copy((char *)&sa.sin_addr, 4, ip);
      |            ^
2 warnings generated.
./load check-socklog-inet unix.a byte.a `cat socket.lib`
ld: warning: option -s is obsolete and being ignored
./check-local socklog socklog-check socklog-conf tryto uncat
Checking socklog...
listening on socklog.check.socket, starting.
foo
0
socklog: fatal: bind(): permission denied
fatal: unable to bind socket: permission denied
/private/tmp/nix-build-socklog-2.1.1.drv-0/admin/socklog-2.1.1/compile/socklog.check: line 18: kill: (6719) - No such process
0
U: foo
U: bar
U: baz
0
socklog failed.
make: *** [Makefile:6: check] Error 1

@mdaniels5757 mdaniels5757 mentioned this pull request Jun 9, 2025
13 tasks
@thunze
Copy link
Member

thunze commented Jun 15, 2025

__darwinAllowLocalNetworking = true; should help here.

@wolfgangwalther wolfgangwalther merged commit e4da1ae into NixOS:master Jun 27, 2025
18 of 19 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 28, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 28, 2025
@petrzjunior petrzjunior deleted the socklog branch July 6, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants