cc-wrapper: tidy logic for implied hardening flags#414842
Merged
risicle merged 1 commit intoNixOS:stagingfrom Jun 9, 2025
Merged
cc-wrapper: tidy logic for implied hardening flags#414842risicle merged 1 commit intoNixOS:stagingfrom
risicle merged 1 commit intoNixOS:stagingfrom
Conversation
this can be done more neatly than my previous just-copy-the-blocks approach
github-actions
bot
added
10.rebuild-darwin: 501+
philiptaron
reviewed
Jun 9, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
I'm not sure my brain was fully working when I wrote this bit.
I often say the same of my own works. LGTM; I'll run the hardening tests, then merge.
philiptaron
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure my brain was fully working when I wrote this bit of #400408. What's committed works fine, but it makes a lot more sense to combine the "Remove unsupported flags" loops.
Tested
tests.hardeningFlagson indicated platforms successfully.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.