Merged
Conversation
Besides updating the version, a patch is applied for building with QT5.11.
Contributor
|
Did you check that the patch doesn't break the build when |
Contributor
Author
|
I did not test it with this option enabled, but this patch just modifies one cpp file that is exclusivly used with qt. |
lukateras
approved these changes
Jun 5, 2018
Contributor
|
@GrahamcOfBorg build vlc vlc_qt5 |
|
Failure on aarch64-linux (full log) Attempted: vlc, vlc_qt5 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: vlc, vlc_qt5 Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: vlc, vlc_qt5 Partial log (click to expand)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides updating the version, a patch is applied for building with
QT5.11.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)