Skip to content

aliases: make aliases supported for 2 years/4 releases #414656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pbsds wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

aliases: make aliases supported for 2 years/4 releases #414656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkgs/top-level/aliases.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ lib: self: super:

# A script to convert old aliases to throws and remove old
# throws can be found in './maintainers/scripts/remove-old-aliases.py'.
# We aim to run it after each nixos release branchoff. Feel free to
Copy link
Member

@Pandapip1 Pandapip1 Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Who is 'we'? The release manager? If so, this should probably be documented in whatever checklist is used. If it's not a defined person at all, I'd be surprised if this ever happens.

Alternatively, there could be a CI that periodically runs the script and opens a new PR. If this is the route that ends up happening, I don't think it would be out of scope to mention that intention here.

Copy link
Member Author

@pbsds pbsds Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went for an ambiguous "we" due to not having put it on any release checklist yet, and instead phrasing it as an open invitation. Once merged we could open a PR to the release-manager repo, then update this text if that gets merged.

The script is too faulty to be run automatically IMO. It should be cherry-picked by a human.

# convert aliases 2-years older than the next nixos release to throws:
# major=$(nix eval --impure --expr 'with import ./lib; versions.major version' --raw)
# minor=$(nix eval --impure --expr 'with import ./lib; versions.minor version' --raw)
# echo ./maintainers/scripts/remove-old-aliases.py --year $(("20$major" - 2)) --month "$minor" --file ./pkgs/top-level/aliases.nix

# Add 'preserve, reason: reason why' after the date if the alias should not be removed.
# Try to keep them to a minimum.
Expand Down