adios2: doCheck with ctestCheckHook#414597
Conversation
github-actions
bot
added
6.topic: python
pkgs/by-name/ad/adios2/package.nix
Outdated
There was a problem hiding this comment.
I think you'd also need to use dontUseNinjaCheck = true for the hook to work, since the derivation uses ninja.
Worth noting though that there doesn't seem to be a use-case for it here. enableParallelChecking also works with plain make/ninja check phase since CMake hook also sets CTEST_PARALLEL_LEVEL env variable and that gets picked up by ctest. Its primary use is to pass additional flags / selectively disable tests in a more ergonomic manner.
There was a problem hiding this comment.
I was meant to use ctestCheckHook to disable some tests failure on x86_64-linux platform, however i managed to fix thouse tests failure. I am opening this pr to see if there exist any tests failure on other platform and would like to disable thouse test failure.
qbisi
force-pushed
the
adios2
branch
3 times, most recently
from
1104d1e to
5e1c292
Compare
pkgs/by-name/ad/adios2/package.nix
Outdated
There was a problem hiding this comment.
Why disable BUILD_TESTING and then reenable it conditionally? Can't this just be this:
| (lib.cmakeBool "BUILD_TESTING" false) | |
| # use vendored gtest as nixpkgs#gtest does not include <iomanip> in <gtest/gtest.h> | |
| (lib.cmakeBool "ADIOS2_USE_EXTERNAL_GTEST" false) | |
| (lib.cmakeBool "BUILD_TESTING" finalAttrs.finalPackage.doCheck) | |
| # use vendored gtest as nixpkgs#gtest does not include <iomanip> in <gtest/gtest.h> | |
| (lib.cmakeBool "ADIOS2_USE_EXTERNAL_GTEST" false) | |
| (lib.cmakeBool "BUILD_TESTING" finalAttrs.finalPackage.doCheck) |
There was a problem hiding this comment.
Thanks for fixing me, i just forgot to delete that line.
adios2_DIR needs to be set to a different value before checkPhase/installPahse.
|
Re-running CI due to a odd failure fixed in #416448 |
|
github-actions
bot
added
the
12.approvals: 1
4 participants
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.