Skip to content

python3Packages.tomlkit: 0.13.2 -> 0.13.3#414471

Merged
kirillrdy merged 1 commit intoNixOS:stagingfrom
MisileLab:python3Packages_tomlkit
Jun 8, 2025
Merged

python3Packages.tomlkit: 0.13.2 -> 0.13.3#414471
kirillrdy merged 1 commit intoNixOS:stagingfrom
MisileLab:python3Packages_tomlkit

Conversation

@MisileLab
Copy link
Contributor

https://github.com/python-poetry/tomlkit/blob/0.13.3/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 6, 2025
@nix-owners nix-owners bot requested a review from jbaum98 June 6, 2025 09:33
@kirillrdy kirillrdy merged commit ecbbc46 into NixOS:staging Jun 8, 2025
16 of 18 checks passed
@MisileLab MisileLab deleted the python3Packages_tomlkit branch June 8, 2025 11:21
@mweinelt
Copy link
Member

Note that this regressed the pkgs.formats tests.

nix-build pkgs/top-level/release.nix -A pkgs-lib-tests

#412425 (comment)

@dtomvan
Copy link
Contributor

dtomvan commented Jun 17, 2025

The changelog mentions python-poetry/tomlkit#387. This is called a fix and not a breaking change, but dependents decided to test the behavior, like nixpkgs and hatch. I think that any test that isn't in our tree we should just disable for now, or do as @mweinelt did in remarshal, just pin to the previous version of tomlkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants