nixos/vector: add graceful shutdown limit option#414311
Merged
happysalada merged 1 commit intoNixOS:masterfrom Jun 12, 2025
Merged
nixos/vector: add graceful shutdown limit option#414311happysalada merged 1 commit intoNixOS:masterfrom
happysalada merged 1 commit intoNixOS:masterfrom
Conversation
dotlambda
reviewed
Jun 5, 2025
Member
|
Please squash. |
Contributor
Author
Thanks. I updated the PR title to comply with that format. Is that sufficient? Or is it desirable that I force push? |
Member
The latter. |
This adds a NixOS module option to configure the Vector cli option `--graceful-shutdown-limit-secs`, https://vector.dev/docs/reference/cli/#vector_graceful_shutdown_limit_secs.
e581f72 to
25a40ea
Compare
happysalada
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to the vector module to set the graceful shutdown limit added in vectordotdev/vector#17479. The option default mirrors the default from the vector cli. Alternatively, the option could be null as to be a no-op if it is not specified.
Eval and ExecStart output testing:
nixosTests:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.