treewide: remove rec when using finalAttrs#414239
Merged
alyssais merged 1 commit intoNixOS:masterfrom Jun 6, 2025
Merged
Conversation
github-actions
bot
added
6.topic: llvm/clang
nix-owners
bot
requested review from
Ericson2314,
RossComputerGuy,
alyssais,
dtzWill,
lovek323,
rrbutani and
sternenseemann
Member
Author
|
phanirithvij
force-pushed
the
finalattrs-norec
branch
from
c6d3569 to
d111626
Compare
alyssais
reviewed
Jun 6, 2025
pkgs/by-name/ha/has/package.nix
Outdated
Member
There was a problem hiding this comment.
Unrelated changes like this, your maintainers changes, or removing unused inputs should go into different commits or different PRs — it's hard enough to review a treewide when it's limited to changing one thing.
Member
There was a problem hiding this comment.
Leaving meta.mainProgram used would be fine — it's different to pname.
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
phanirithvij
force-pushed
the
finalattrs-norec
branch
from
d111626 to
b8ade8b
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some derviations are still using
recalong withfinalAttrsThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.