haskell generic-builder: Use strictDeps always

[Ericson2314]

Motivation for this change

This helps avoid the ARG_MAX issues we've been having, and is generally a good idea to ensure cross comparability anyways.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[peti]

https://hydra.nixos.org/eval/1460999 is a build of the Haskell package set with this change applied.

[colonelpanic8]

@peti @Ericson2314 Is there anything blocking merge here?

[peti]

Yes, the test builds are not complete yet.

[colonelpanic8]

@Ericson2314 It seems like strictDeps does not ameliorate this issue when it is encountered with stack builds (or maybe I'm doing something totally incorrectly). Do you have any idea how to fix the stack build of taffybar?

[colonelpanic8]

@Ericson2314 Actually, it seems that what happens when you enable crossConfig/stictDeps with the stack builder is that all of the haskell-gi generated bindings fail with

setup: The program 'pkg-config' version >=0.9.0 is required but it could not

I suspect that this is probably because the paths that are passed to the stack build are not properly inherited in the builds for each haskell package, but I have to say that I'm pretty out of my depth with this haskell/stack/nix stuff.

[peti]

This change breaks haskell.packages.ghc843.hspec-discover. See the "new failing jobs" tab at https://hydra.nixos.org/eval/1460999 for further details.

[Ericson2314]

Weird! This is because GHC cannot find the testsuite from the same package to use a pre-processor. We have tests for this in Cabal https://github.com/haskell/cabal/tree/master/cabal-testsuite/PackageTests/BuildToolDepends; I'd know as I wrote them!

[Ericson2314]

https://hydra.nixos.org/eval/1464500

[Ericson2314]

CC @kirelagin @angerman @matthewbauer

[Ericson2314]

Looks like there's some lingering issues with build tools: hspec-discover despite my patch, and maybealex too. If anyone has any ideas I'd love to hear them.

[Ericson2314]

Rebased on #42247 which should work to keep things moving.

[Ericson2314]

https://hydra.nixos.org/eval/1465142. It will probably fail again, but I'd love to be wrong!

[matthewbauer]

I think this needs to be done for hspec-core (and maybe other hspec stuff) as well:

ghc: could not execute: hspec-meta-discover

[Ericson2314]

OK I'll try

[Ericson2314]

Ah ok fixed. didn't realize this was the executable from hspec-meta, not hspec-discover.

[Ericson2314]

OK fixed this build, reevaluating. We'll see what fails.

[Ericson2314]

Huh. My evaluation hydra evaluation is stuck pending, and just disappeared before that.

[domenkozar]

This change requires a lot of manual overrides. I think solution @angerman is proposing is less intrusive. Another way is to actually fix the commit that made MAX_ARGS explode: https://github.com/NixOS/nixpkgs/pull/41939/files#diff-360bed088faac7580cee137eeffb39e0R279

[Ericson2314]

@domenkozar the big change motivating all the overrides here is we're being explicit for the first time about when we need a binary from another package or just its library. So I think these changes will be very good for multiple outputs (#32629). Also, Cabal 3.0 due at the end of the year will remove the non-new-build stuff, in which case being explicit in the Cabal file will also be required.

My guess is Cabal will need to come up with some sort of back-compat story, and we can replace most the overrides with that, probably implemented in Cabal2nix but who knows.

[domenkozar]

Oh you mean stuff like this: sol/with-location#1

OK, but why is this needed in order to unbreak ARG_MAX? :)

[domenkozar]

Could someone pull in domenkozar@4149778

[matthewbauer]

Merging for today because of the many breakages on macOS. There are still breakages for now but we should be below 400. strictDeps seems to be the only way to fix this without also breaking cross compilation of haskell.

[domenkozar]

@matthewbauer btw adding build tool dependencies should go to configuration-nix as it's not version dependent :) Thanks!

[domenkozar]

FYI: it was reverted and I agree with @peti we can autogenerate these: NixOS/cabal2nix#356