gradia: init at 1.4.3

[Cameo007]

Gradia is a screenshot editing tool with the option to add a colored background, draw shapes or write text on screenshots.

https://github.com/AlexanderVanhee/Gradia

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
• NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[liberodark]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414010

---

x86_64-linux

✅ 1 package built:

• gradia

[liberodark]

LGTM

Build & Run :

[Henry-Hiles]

Tested, works perfectly. Interestingly not all the deps from gradia are in here, namely pycairo and pygobject-stubs, but it works okay, so I guess we are good!

[LordGrimmauld]

I have some nits, nothing obviously immediately wrong with this PR.

[Henry-Hiles]

LGTM, tested and good

[LordGrimmauld]

Package works. Builds on x86_64-linux and aarch64-linux, as well as cross for both of those platforms.

On x86_64, both the native and cross builds work, supporting screenshots, clipboard and everything. I am honestly a bit surprised, usually these break hard outside flatpak on sway....

One thing i found: The "move" tool to move things you have drawn will spam the log with the following:

Traceback (most recent call last):
  File "/nix/store/3rw1qlb0dqwy0ybwzhffr1z62h7ns9h9-gradia-1.4.0/share/gradia/gradia/overlay/drawing_overlay.py", line 538, in _on_draw
    self._draw_selection_box(cr, scale)
  File "/nix/store/3rw1qlb0dqwy0ybwzhffr1z62h7ns9h9-gradia-1.4.0/share/gradia/gradia/overlay/drawing_overlay.py", line 194, in _draw_selection_box
    cr.set_source_rgba(*accent)
TypeError: Context.set_source_rgba() argument after * must be an iterable, not RGBA

However, this might well be an upstream bug, and it does seam to work.
Overall, lgtm!

[AlexanderVanhee]

One thing i found: The "move" tool to move things you have drawn will spam the log with the following
I have not been able to replicate this on the v1.4.0 of the Flatpak from Flathub.

[LordGrimmauld]

Right. Then my guess is on a library mismatch betweehn your pyproject toml and what is in nixpkgs (we mostly ignore pyproject toml). That said, we did not need relaxDeps here, so in theory these versions are allowed. One would have to now go and compare the dep versions between flatpak and nix i guess. Or read the code and look at the call, see what it takes to make it happy.

[Aleksanaa]

https://github.com/AlexanderVanhee/Gradia/blob/0a66322a2ddd7152035802c7b0ed95a7001b6333/gradia/overlay/drawing_overlay.py#L215

This should probably be **accent, not *accent.

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/method.StyleManager.get_accent_color_rgba.html
https://docs.gtk.org/gdk4/struct.RGBA.html
https://pycairo.readthedocs.io/en/latest/reference/context.html#cairo.Context.set_source_rgba

[Aleksanaa]

Better to write a patch and submit upstream.

[Cameo007]

https://github.com/AlexanderVanhee/Gradia/blob/0a66322a2ddd7152035802c7b0ed95a7001b6333/gradia/overlay/drawing_overlay.py#L215

This should probably be **accent, not *accent.

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/method.StyleManager.get_accent_color_rgba.html https://docs.gtk.org/gdk4/struct.RGBA.html https://pycairo.readthedocs.io/en/latest/reference/context.html#cairo.Context.set_source_rgba

But how does it work in the flatpak? Shouldn't it then also log an error there?

[LordGrimmauld]

Flatpak might just blackhole those errors instead of logging them? It is not actually a hard crash.

[wolfgangwalther]

Re-running CI due to a odd failure fixed in #416448

[LordGrimmauld]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414010
Commit: ffbd6bdb409c07d222426ad3d756de2941e4acbd

---

x86_64-linux

✅ 1 package built:

• gradia

[LordGrimmauld]

Still works, waiting for a merge...

[nixpkgs-ci]

Successfully created backport PR for release-25.05:

• [Backport release-25.05] gradia: init at 1.4.3 #418761