lowdown: 1.3.2 -> 2.0.2, nixVersions.nix_2_24: fix build against lowdown 2.0.2; lix: apply patches for lowdown >= 1.4#413730
Merged
sternenseemann merged 3 commits intoNixOS:masterfrom Jul 28, 2025
Conversation
Member
|
Thanks for pinging us, I will be able to tend to this only starting next week if that's OK. If this is urgent, please let me know. |
Contributor
Author
|
@RaitoBezarius thanks! There's no rush at all. The only major consumers of lowdown are just lix/nix so we can take our time here. |
3 tasks
6072220 to
6b8fa34
Compare
6b8fa34 to
413d344
Compare
sternenseemann
approved these changes
Jul 24, 2025
SuperSandro2000
approved these changes
Jul 26, 2025
roberth
approved these changes
Jul 28, 2025
Member
roberth
left a comment
There was a problem hiding this comment.
Seems ok on the Nix side. Lix also good to merge?
lf-
approved these changes
Jul 28, 2025
3 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Supersedes #368499.
lowdownitself needs a switch from gmake to bmake because upstream has started using FreeBSD dialect.Draft becauselixwill fail to build. @RaitoBezarius, @lf- how should we go about this? Would pinning tolowdown_1_3be preferable or could lix get a patch similar to @trofi's NixOS/nix#12115 backported?nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.