Skip to content

Comments

bitwarden: 2025.4.2 -> 2025.5.0#413104

Merged
sikmir merged 1 commit intoNixOS:masterfrom
YodaDaCoda:bitwarden/2025.5.0
Jun 3, 2025
Merged

bitwarden: 2025.4.2 -> 2025.5.0#413104
sikmir merged 1 commit intoNixOS:masterfrom
YodaDaCoda:bitwarden/2025.5.0

Conversation

@YodaDaCoda
Copy link
Contributor

Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2025.5.0

Required a minor tweak to one of the patch files, else the hunk wouldn't apply.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 2, 2025
@nix-owners nix-owners bot requested a review from amarshall June 2, 2025 02:53
@momeemt
Copy link
Member

momeemt commented Jun 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 413104


x86_64-linux

✅ 1 package built:
  • bitwarden-desktop

Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momeemt momeemt added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 3, 2025
@sikmir sikmir merged commit 872b531 into NixOS:master Jun 3, 2025
18 of 19 checks passed
@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants