pypy3Packages.pyflakes: disable another broken test by FliegendeWurst · Pull Request #412923 · NixOS/nixpkgs

FliegendeWurst · 2025-06-01T12:12:32Z

PyCQA/pyflakes#779

Things done

momeemt · 2025-06-02T14:33:25Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 412923

`x86_64-linux`

❌ 1 package failed to build:

tests.writers.simple.pypy3NoLibs

momeemt · 2025-06-02T14:43:34Z

I failed to build this package on x86_64-linux.

build log

Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing pypa-build-hook
Using pypaBuildPhase
Sourcing python-runtime-deps-check-hook
Using pythonRuntimeDepsCheckHook
Sourcing pypa-install-hook
Using pypaInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing pytest-check-hook
Using pytestCheckPhase
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/18v7839aypda35qq8ymxxvc44dwmmwn3-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file "source/tox.ini"
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing pypaBuildPhase
Creating a wheel...
pypa build flags: --no-isolation --outdir dist/ --wheel
* Getting build dependencies for wheel...
/nix/store/5y0hb08wbb1zwin5h6z7xyvr72kldh9n-pypy3.11-setuptools-78.1.0/lib/pypy3.11/site-packages/setuptools/dist.py:759: Setu>
!!

        ********************************************************************************
        Please consider removing the following classifiers in favor of a SPDX license expression:

        License :: OSI Approved :: MIT License

        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
        ********************************************************************************

!!
  self._finalize_license_expression()
running egg_info
creating pycodestyle.egg-info
writing pycodestyle.egg-info/PKG-INFO
writing dependency_links to pycodestyle.egg-info/dependency_links.txt
writing entry points to pycodestyle.egg-info/entry_points.txt
writing top-level names to pycodestyle.egg-info/top_level.txt
writing manifest file 'pycodestyle.egg-info/SOURCES.txt'
reading manifest file 'pycodestyle.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'pycodestyle.egg-info/SOURCES.txt'
* Building wheel...
/nix/store/5y0hb08wbb1zwin5h6z7xyvr72kldh9n-pypy3.11-setuptools-78.1.0/lib/pypy3.11/site-packages/setuptools/dist.py:759: Setu>
!!

        ********************************************************************************
        Please consider removing the following classifiers in favor of a SPDX license expression:

        License :: OSI Approved :: MIT License

        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
        ********************************************************************************

!!
  self._finalize_license_expression()
running bdist_wheel
/nix/store/5y0hb08wbb1zwin5h6z7xyvr72kldh9n-pypy3.11-setuptools-78.1.0/lib/pypy3.11/site-packages/setuptools/_distutils/cmd.py>
!!

        ********************************************************************************
        With Python 2.7 end-of-life, support for building universal wheels
        (i.e., wheels that support both Python 2 and Python 3)
        is being obviated.
        Please discontinue using this option, or if you still need it,
        file an issue with pypa/setuptools describing your use case.

        By 2025-Aug-30, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.
        ********************************************************************************

!!
  self.finalize_options()
running build
running build_py
creating build/lib
copying pycodestyle.py -> build/lib
running egg_info
writing pycodestyle.egg-info/PKG-INFO
writing dependency_links to pycodestyle.egg-info/dependency_links.txt
writing entry points to pycodestyle.egg-info/entry_points.txt
writing top-level names to pycodestyle.egg-info/top_level.txt
reading manifest file 'pycodestyle.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'pycodestyle.egg-info/SOURCES.txt'
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
creating build/bdist.linux-x86_64/wheel
copying build/lib/pycodestyle.py -> build/bdist.linux-x86_64/wheel/.
running install_egg_info
Copying pycodestyle.egg-info to build/bdist.linux-x86_64/wheel/./pycodestyle-2.13.0-py3.11.egg-info
running install_scripts
creating build/bdist.linux-x86_64/wheel/pycodestyle-2.13.0.dist-info/WHEEL
creating '/build/source/dist/.tmp-1tmacd5y/pycodestyle-2.13.0-py2.py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel>
adding 'pycodestyle.py'
adding 'pycodestyle-2.13.0.dist-info/licenses/LICENSE'
adding 'pycodestyle-2.13.0.dist-info/METADATA'
adding 'pycodestyle-2.13.0.dist-info/WHEEL'
adding 'pycodestyle-2.13.0.dist-info/entry_points.txt'
adding 'pycodestyle-2.13.0.dist-info/top_level.txt'
adding 'pycodestyle-2.13.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built pycodestyle-2.13.0-py2.py3-none-any.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for pycodestyle-2.13.0-py2.py3-none-any.whl
Finished executing pythonRuntimeDepsCheck
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
Executing pypaInstallPhase
Successfully installed pycodestyle-2.13.0-py2.py3-none-any.whl
Finished executing pypaInstallPhase
Running phase: pythonOutputDistPhase
@nix { "action": "setPhase", "phase": "pythonOutputDistPhase" }
Executing pythonOutputDistPhase
Finished executing pythonOutputDistPhase
Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
shrinking RPATHs of ELF executables and libraries in /nix/store/wlh3xf3cvx08vdlrwsa62w8217pgrpkl-pypy3.11-pycodestyle-2.13.0
checking for references to /build/ in /nix/store/wlh3xf3cvx08vdlrwsa62w8217pgrpkl-pypy3.11-pycodestyle-2.13.0...
patching script interpreter paths in /nix/store/wlh3xf3cvx08vdlrwsa62w8217pgrpkl-pypy3.11-pycodestyle-2.13.0
stripping (with command strip and flags -S -p) in  /nix/store/wlh3xf3cvx08vdlrwsa62w8217pgrpkl-pypy3.11-pycodestyle-2.13.0/lib>
shrinking RPATHs of ELF executables and libraries in /nix/store/vg2v9805183r10dh8qjv9ry08j5kssjk-pypy3.11-pycodestyle-2.13.0-d>
checking for references to /build/ in /nix/store/vg2v9805183r10dh8qjv9ry08j5kssjk-pypy3.11-pycodestyle-2.13.0-dist...
patching script interpreter paths in /nix/store/vg2v9805183r10dh8qjv9ry08j5kssjk-pypy3.11-pycodestyle-2.13.0-dist
Rewriting #!/nix/store/8r7xm42qv03pbrnkhr85wazxajafx7hd-pypy3.11-7.3.19/bin/pypy3.11 to #!/nix/store/8r7xm42qv03pbrnkhr85wazxa>
wrapping `/nix/store/wlh3xf3cvx08vdlrwsa62w8217pgrpkl-pypy3.11-pycodestyle-2.13.0/bin/pycodestyle'...
Executing pythonRemoveTestsDir
Finished executing pythonRemoveTestsDir
Running phase: installCheckPhase
@nix { "action": "setPhase", "phase": "installCheckPhase" }
no Makefile or custom installCheckPhase, doing nothing
Running phase: pythonCatchConflictsPhase
@nix { "action": "setPhase", "phase": "pythonCatchConflictsPhase" }
Running phase: pythonRemoveBinBytecodePhase
@nix { "action": "setPhase", "phase": "pythonRemoveBinBytecodePhase" }
Running phase: pythonImportsCheckPhase
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: pycodestyle
Running phase: pytestCheckPhase
@nix { "action": "setPhase", "phase": "pytestCheckPhase" }
Executing pytestCheckPhase
pytest flags: -m pytest
============================= test session starts ==============================
platform linux -- Python 3.11.11[pypy-7.3.19-final], pytest-8.3.5, pluggy-1.5.0
rootdir: /build/source
collecting ... ^Mcollected 769 items

tests/test_E101.py .                                                     [  0%]
tests/test_E901.py ..                                                    [  0%]
tests/test_all.py .                                                      [  0%]
tests/test_api.py F.............                                         [  2%]
tests/test_blank_lines.py .......................                        [  5%]
tests/test_data.py ..................................................... [ 12%]
........................................................................ [ 21%]
........................................................................ [ 30%]
........................................................................ [ 40%]
........................................................................ [ 49%]
........................................................................ [ 59%]
.....sssssss.................................................            [ 66%]
tests/test_parser.py ....                                                [ 67%]
tests/test_pycodestyle.py ........                                       [ 68%]
tests/test_self_doctests.py ............................................ [ 74%]
........................................................................ [ 83%]
........................................................................ [ 92%]
...............................................                          [ 99%]
........................................................................ [ 92%]
...............................................                          [ 99%]
@nix { "action": "setPhase", "phase": "installCheckPhase" }
no Makefile or custom installCheckPhase, doing nothing
Running phase: pythonCatchConflictsPhase
@nix { "action": "setPhase", "phase": "pythonCatchConflictsPhase" }
Running phase: pythonRemoveBinBytecodePhase
@nix { "action": "setPhase", "phase": "pythonRemoveBinBytecodePhase" }
Running phase: pythonImportsCheckPhase
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: pycodestyle
Running phase: pytestCheckPhase
@nix { "action": "setPhase", "phase": "pytestCheckPhase" }
Executing pytestCheckPhase
pytest flags: -m pytest
============================= test session starts ==============================
platform linux -- Python 3.11.11[pypy-7.3.19-final], pytest-8.3.5, pluggy-1.5.0
rootdir: /build/source
collecting ... ^Mcollected 769 items

tests/test_E101.py .                                                     [  0%]
tests/test_E901.py ..                                                    [  0%]
tests/test_all.py .                                                      [  0%]
tests/test_api.py F.............                                         [  2%]
tests/test_blank_lines.py .......................                        [  5%]
tests/test_data.py ..................................................... [ 12%]
........................................................................ [ 21%]
........................................................................ [ 30%]
........................................................................ [ 40%]
........................................................................ [ 49%]
........................................................................ [ 59%]
.....sssssss.................................................            [ 66%]
tests/test_parser.py ....                                                [ 67%]
tests/test_pycodestyle.py ........                                       [ 68%]
tests/test_self_doctests.py ............................................ [ 74%]
........................................................................ [ 83%]
........................................................................ [ 92%]
...............................................                          [ 99%]
tests/test_shell.py ......                                               [ 99%]
tests/test_util.py .                                                     [100%]

=================================== FAILURES ===================================
_______________________ APITestCase.test_check_nullbytes _______________________

self = <tests.test_api.APITestCase testMethod=test_check_nullbytes>

    def test_check_nullbytes(self):
        pycodestyle.register_check(DummyChecker, ['Z701'])

        pep8style = pycodestyle.StyleGuide()
        count_errors = pep8style.input_file('stdin', lines=['\x00\n'])

        stdout = sys.stdout.getvalue()
        if sys.version_info < (3, 11, 4):  # pragma: <3.11 cover
            expected = ["stdin:1:1: E901 ValueError: source code string cannot contain null bytes"]  # noqa: E501
        elif sys.version_info < (3, 12):  # pragma: <3.12 cover  # pragma: >=3.11 cover  # noqa: E501
            expected = ["stdin:1:1: E901 SyntaxError: source code string cannot contain null bytes"]  # noqa: E501
        else:  # pragma: >=3.12 cover
            expected = [
                "stdin:1:1: E901 SyntaxError: source code string cannot contain null bytes",   # noqa: E501
                "stdin:1:1: E901 TokenError: source code cannot contain null bytes",   # noqa: E501
            ]
>       self.assertEqual(stdout.splitlines(), expected)
E       AssertionError: Lists differ: ['stdin:1:1: E901 ValueError: source code string cannot contain null bytes'] != ['stdin:>
E
E       First differing element 0:
E       'stdin:1:1: E901 ValueError: source code string cannot contain null bytes'
E       'stdin:1:1: E901 SyntaxError: source code string cannot contain null bytes'
E
E       - ['stdin:1:1: E901 ValueError: source code string cannot contain null bytes']
E       ?                   ^ ^^^
E
E       + ['stdin:1:1: E901 SyntaxError: source code string cannot contain null bytes']
E       ?                   ^^^^ ^

tests/test_api.py:340: AssertionError
=========================== short test summary info ============================
FAILED tests/test_api.py::APITestCase::test_check_nullbytes - AssertionError: Lists differ: ['stdin:1:1: E901 ValueError: sour>
=================== 1 failed, 761 passed, 7 skipped in 5.80s ===================

FliegendeWurst · 2025-06-02T15:49:58Z

Oh, then this PR depends on #412921.

SuperSandro2000 · 2025-08-17T23:14:20Z

We picked this into #431707 to properly test this.

pypy3Packages.pyflakes: disable another broken test

9722cbf

FliegendeWurst added the backport release-25.05 label Jun 1, 2025

FliegendeWurst mentioned this pull request Jun 2, 2025

pypy3Packages.pycodestyle: disable broken test #413268

Closed

13 tasks

FliegendeWurst mentioned this pull request Jun 2, 2025

pypy3Packages.pycodestyle: disable broken test #412921

Merged

13 tasks

nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025

MaxWipfli mentioned this pull request Aug 17, 2025

pypy: make CFFI builds find libsqlite3 #431707

Merged

13 tasks

SuperSandro2000 closed this Aug 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

pypy3Packages.pyflakes: disable another broken test#412923

pypy3Packages.pyflakes: disable another broken test#412923
FliegendeWurst wants to merge 1 commit intoNixOS:masterfrom
FliegendeWurst:pyflakes-pypy

FliegendeWurst commented Jun 1, 2025

Uh oh!

momeemt commented Jun 2, 2025

Uh oh!

momeemt commented Jun 2, 2025

Uh oh!

FliegendeWurst commented Jun 2, 2025 •

edited

Loading

Uh oh!

SuperSandro2000 commented Aug 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

FliegendeWurst commented Jun 1, 2025

Things done

Uh oh!

momeemt commented Jun 2, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

momeemt commented Jun 2, 2025

Uh oh!

FliegendeWurst commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SuperSandro2000 commented Aug 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`nixpkgs-review` result

`x86_64-linux`

FliegendeWurst commented Jun 2, 2025 •

edited

Loading